massive refactoring to switch from camelCase to snake_case:

historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.

However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.

To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.

This is a massive change, and may result in some bugs.
This commit is contained in:
Goffi 2023-04-08 13:54:42 +02:00
commit 6a6f15707a

View file

@ -29,96 +29,96 @@ class FakeXEP_0045Test(helpers.SatTestCase):
self.host = helpers.FakeSAT()
self.plugin = helpers_plugins.FakeXEP_0045(self.host)
def test_joinRoom(self):
self.plugin.joinRoom(0, 0)
self.assertEqual("test", self.plugin.getNick(0, 0))
self.assertEqual(None, self.plugin.getNickOfUser(0, 0, 0))
self.assertEqual(None, self.plugin.getNickOfUser(0, 1, 0))
self.assertEqual(None, self.plugin.getNickOfUser(0, 2, 0))
self.assertEqual(None, self.plugin.getNickOfUser(0, 3, 0))
self.assertEqual("", self.plugin.getNick(0, 1))
self.assertEqual(None, self.plugin.getNickOfUser(0, 0, 1))
self.assertEqual(None, self.plugin.getNickOfUser(0, 1, 1))
self.assertEqual(None, self.plugin.getNickOfUser(0, 2, 1))
self.assertEqual(None, self.plugin.getNickOfUser(0, 3, 1))
self.assertEqual("", self.plugin.getNick(0, 2))
self.assertEqual(None, self.plugin.getNickOfUser(0, 0, 2))
self.assertEqual(None, self.plugin.getNickOfUser(0, 1, 2))
self.assertEqual(None, self.plugin.getNickOfUser(0, 2, 2))
self.assertEqual(None, self.plugin.getNickOfUser(0, 3, 2))
self.assertEqual("", self.plugin.getNick(0, 3))
self.assertEqual(None, self.plugin.getNickOfUser(0, 0, 3))
self.assertEqual(None, self.plugin.getNickOfUser(0, 1, 3))
self.assertEqual(None, self.plugin.getNickOfUser(0, 2, 3))
self.assertEqual(None, self.plugin.getNickOfUser(0, 3, 3))
self.plugin.joinRoom(0, 1)
self.assertEqual("test", self.plugin.getNick(0, 0))
self.assertEqual(None, self.plugin.getNickOfUser(0, 0, 0))
self.assertEqual("sender", self.plugin.getNickOfUser(0, 1, 0))
self.assertEqual("sender", self.plugin.getNickOfUser(0, 2, 0))
self.assertEqual(None, self.plugin.getNickOfUser(0, 3, 0))
self.assertEqual("sender", self.plugin.getNick(0, 1))
self.assertEqual("test", self.plugin.getNickOfUser(0, 0, 1))
self.assertEqual(None, self.plugin.getNickOfUser(0, 1, 1))
self.assertEqual(None, self.plugin.getNickOfUser(0, 2, 1))
self.assertEqual(None, self.plugin.getNickOfUser(0, 3, 1))
self.assertEqual("", self.plugin.getNick(0, 2))
self.assertEqual(None, self.plugin.getNickOfUser(0, 0, 2))
self.assertEqual(None, self.plugin.getNickOfUser(0, 1, 2))
self.assertEqual(None, self.plugin.getNickOfUser(0, 2, 2))
self.assertEqual(None, self.plugin.getNickOfUser(0, 3, 2))
self.assertEqual("", self.plugin.getNick(0, 3))
self.assertEqual(None, self.plugin.getNickOfUser(0, 0, 3))
self.assertEqual(None, self.plugin.getNickOfUser(0, 1, 3))
self.assertEqual(None, self.plugin.getNickOfUser(0, 2, 3))
self.assertEqual(None, self.plugin.getNickOfUser(0, 3, 3))
self.plugin.joinRoom(0, 2)
self.assertEqual("test", self.plugin.getNick(0, 0))
self.assertEqual(None, self.plugin.getNickOfUser(0, 0, 0))
self.assertEqual("sender", self.plugin.getNickOfUser(0, 1, 0))
self.assertEqual("sender", self.plugin.getNickOfUser(0, 2, 0))
self.assertEqual(None, self.plugin.getNickOfUser(0, 3, 0))
self.assertEqual("sender", self.plugin.getNick(0, 1))
self.assertEqual("test", self.plugin.getNickOfUser(0, 0, 1))
def test_join_room(self):
self.plugin.join_room(0, 0)
self.assertEqual("test", self.plugin.get_nick(0, 0))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 0, 0))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 1, 0))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 2, 0))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 3, 0))
self.assertEqual("", self.plugin.get_nick(0, 1))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 0, 1))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 1, 1))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 2, 1))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 3, 1))
self.assertEqual("", self.plugin.get_nick(0, 2))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 0, 2))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 1, 2))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 2, 2))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 3, 2))
self.assertEqual("", self.plugin.get_nick(0, 3))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 0, 3))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 1, 3))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 2, 3))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 3, 3))
self.plugin.join_room(0, 1)
self.assertEqual("test", self.plugin.get_nick(0, 0))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 0, 0))
self.assertEqual("sender", self.plugin.get_nick_of_user(0, 1, 0))
self.assertEqual("sender", self.plugin.get_nick_of_user(0, 2, 0))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 3, 0))
self.assertEqual("sender", self.plugin.get_nick(0, 1))
self.assertEqual("test", self.plugin.get_nick_of_user(0, 0, 1))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 1, 1))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 2, 1))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 3, 1))
self.assertEqual("", self.plugin.get_nick(0, 2))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 0, 2))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 1, 2))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 2, 2))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 3, 2))
self.assertEqual("", self.plugin.get_nick(0, 3))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 0, 3))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 1, 3))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 2, 3))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 3, 3))
self.plugin.join_room(0, 2)
self.assertEqual("test", self.plugin.get_nick(0, 0))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 0, 0))
self.assertEqual("sender", self.plugin.get_nick_of_user(0, 1, 0))
self.assertEqual("sender", self.plugin.get_nick_of_user(0, 2, 0))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 3, 0))
self.assertEqual("sender", self.plugin.get_nick(0, 1))
self.assertEqual("test", self.plugin.get_nick_of_user(0, 0, 1))
self.assertEqual(
"sender", self.plugin.getNickOfUser(0, 1, 1)
"sender", self.plugin.get_nick_of_user(0, 1, 1)
) # Const.JID[2] is in the roster for Const.PROFILE[1]
self.assertEqual("sender", self.plugin.getNickOfUser(0, 2, 1))
self.assertEqual(None, self.plugin.getNickOfUser(0, 3, 1))
self.assertEqual("sender", self.plugin.getNick(0, 2))
self.assertEqual("test", self.plugin.getNickOfUser(0, 0, 2))
self.assertEqual("sender", self.plugin.getNickOfUser(0, 1, 2))
self.assertEqual("sender", self.plugin.get_nick_of_user(0, 2, 1))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 3, 1))
self.assertEqual("sender", self.plugin.get_nick(0, 2))
self.assertEqual("test", self.plugin.get_nick_of_user(0, 0, 2))
self.assertEqual("sender", self.plugin.get_nick_of_user(0, 1, 2))
self.assertEqual(
"sender", self.plugin.getNickOfUser(0, 2, 2)
"sender", self.plugin.get_nick_of_user(0, 2, 2)
) # Const.JID[1] is in the roster for Const.PROFILE[2]
self.assertEqual(None, self.plugin.getNickOfUser(0, 3, 2))
self.assertEqual("", self.plugin.getNick(0, 3))
self.assertEqual(None, self.plugin.getNickOfUser(0, 0, 3))
self.assertEqual(None, self.plugin.getNickOfUser(0, 1, 3))
self.assertEqual(None, self.plugin.getNickOfUser(0, 2, 3))
self.assertEqual(None, self.plugin.getNickOfUser(0, 3, 3))
self.plugin.joinRoom(0, 3)
self.assertEqual("test", self.plugin.getNick(0, 0))
self.assertEqual(None, self.plugin.getNickOfUser(0, 0, 0))
self.assertEqual("sender", self.plugin.getNickOfUser(0, 1, 0))
self.assertEqual("sender", self.plugin.getNickOfUser(0, 2, 0))
self.assertEqual("sender_", self.plugin.getNickOfUser(0, 3, 0))
self.assertEqual("sender", self.plugin.getNick(0, 1))
self.assertEqual("test", self.plugin.getNickOfUser(0, 0, 1))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 3, 2))
self.assertEqual("", self.plugin.get_nick(0, 3))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 0, 3))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 1, 3))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 2, 3))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 3, 3))
self.plugin.join_room(0, 3)
self.assertEqual("test", self.plugin.get_nick(0, 0))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 0, 0))
self.assertEqual("sender", self.plugin.get_nick_of_user(0, 1, 0))
self.assertEqual("sender", self.plugin.get_nick_of_user(0, 2, 0))
self.assertEqual("sender_", self.plugin.get_nick_of_user(0, 3, 0))
self.assertEqual("sender", self.plugin.get_nick(0, 1))
self.assertEqual("test", self.plugin.get_nick_of_user(0, 0, 1))
self.assertEqual(
"sender", self.plugin.getNickOfUser(0, 1, 1)
"sender", self.plugin.get_nick_of_user(0, 1, 1)
) # Const.JID[2] is in the roster for Const.PROFILE[1]
self.assertEqual("sender", self.plugin.getNickOfUser(0, 2, 1))
self.assertEqual("sender_", self.plugin.getNickOfUser(0, 3, 1))
self.assertEqual("sender", self.plugin.getNick(0, 2))
self.assertEqual("test", self.plugin.getNickOfUser(0, 0, 2))
self.assertEqual("sender", self.plugin.getNickOfUser(0, 1, 2))
self.assertEqual("sender", self.plugin.get_nick_of_user(0, 2, 1))
self.assertEqual("sender_", self.plugin.get_nick_of_user(0, 3, 1))
self.assertEqual("sender", self.plugin.get_nick(0, 2))
self.assertEqual("test", self.plugin.get_nick_of_user(0, 0, 2))
self.assertEqual("sender", self.plugin.get_nick_of_user(0, 1, 2))
self.assertEqual(
"sender", self.plugin.getNickOfUser(0, 2, 2)
"sender", self.plugin.get_nick_of_user(0, 2, 2)
) # Const.JID[1] is in the roster for Const.PROFILE[2]
self.assertEqual("sender_", self.plugin.getNickOfUser(0, 3, 2))
self.assertEqual("sender_", self.plugin.getNick(0, 3))
self.assertEqual("test", self.plugin.getNickOfUser(0, 0, 3))
self.assertEqual("sender", self.plugin.getNickOfUser(0, 1, 3))
self.assertEqual("sender", self.plugin.getNickOfUser(0, 2, 3))
self.assertEqual(None, self.plugin.getNickOfUser(0, 3, 3))
self.assertEqual("sender_", self.plugin.get_nick_of_user(0, 3, 2))
self.assertEqual("sender_", self.plugin.get_nick(0, 3))
self.assertEqual("test", self.plugin.get_nick_of_user(0, 0, 3))
self.assertEqual("sender", self.plugin.get_nick_of_user(0, 1, 3))
self.assertEqual("sender", self.plugin.get_nick_of_user(0, 2, 3))
self.assertEqual(None, self.plugin.get_nick_of_user(0, 3, 3))