massive refactoring to switch from camelCase to snake_case:

historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.

However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.

To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.

This is a massive change, and may result in some bugs.
This commit is contained in:
Goffi 2023-04-08 13:54:42 +02:00
commit 6a6f15707a

View file

@ -59,7 +59,7 @@ class XEP_0447:
def __init__(self, host):
self.host = host
log.info(_("XEP-0447 (Stateless File Sharing) plugin initialization"))
host.registerNamespace("sfs", NS_SFS)
host.register_namespace("sfs", NS_SFS)
self._sources_handlers = {}
self._u = host.plugins["XEP-0103"]
self._hints = host.plugins["XEP-0334"]
@ -150,7 +150,7 @@ class XEP_0447:
if self._http_upload is None:
return False
try:
await self._http_upload.getHTTPUploadEntity(client)
await self._http_upload.get_http_upload_entity(client)
except exceptions.NotFound:
return False
else:
@ -334,7 +334,7 @@ class XEP_0447:
"There should not be more that one attachment at this point"
)
await self._attach.upload_files(client, data)
self._hints.addHintElements(data["xml"], [self._hints.HINT_STORE])
self._hints.add_hint_elements(data["xml"], [self._hints.HINT_STORE])
for attachment in attachments:
try:
file_hash = (attachment["hash_algo"], attachment["hash"])