erebion/libervia-backend
Watch
1
0
Fork
You've already forked libervia-backend
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

massive refactoring to switch from camelCase to snake_case:

Browse source 
historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.

However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.

To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.

This is a massive change, and may result in some bugs.
This commit is contained in:
Goffi 2023-04-08 13:54:42 +02:00
commit 6a6f15707a
1 changed files with 9945 additions and 9945 deletions
Download patch file Download diff file Expand all files Collapse all files

12
sat/plugins/plugin_xep_0261.py
View file

@ -56,14 +56,14 @@ class XEP_0261(object):
self.host = host
self._j = host.plugins["XEP-0166"] # shortcut to access jingle
self._ibb = host.plugins["XEP-0047"] # and in-band bytestream
self._j.registerTransport(
self._j.register_transport(
NS_JINGLE_IBB, self._j.TRANSPORT_STREAMING, self, -10000
) # must be the lowest priority
def getHandler(self, client):
def get_handler(self, client):
return XEP_0261_handler()
def jingleSessionInit(self, client, session, content_name):
def jingle_session_init(self, client, session, content_name):
transport_elt = domish.Element((NS_JINGLE_IBB, "transport"))
content_data = session["contents"][content_name]
transport_data = content_data["transport_data"]
@ -72,7 +72,7 @@ class XEP_0261(object):
transport_elt["sid"] = transport_data["sid"] = str(uuid.uuid4())
return transport_elt
def jingleHandler(self, client, action, session, content_name, transport_elt):
def jingle_handler(self, client, action, session, content_name, transport_elt):
content_data = session["contents"][content_name]
transport_data = content_data["transport_data"]
if action in (
@ -90,12 +90,12 @@ class XEP_0261(object):
stream_object = content_data["stream_object"]
if action == self._j.A_START:
block_size = transport_data["block_size"]
d = self._ibb.startStream(
d = self._ibb.start_stream(
client, stream_object, local_jid, peer_jid, sid, block_size
)
d.chainDeferred(content_data["finished_d"])
else:
d = self._ibb.createSession(
d = self._ibb.create_session(
client, stream_object, local_jid, peer_jid, sid)
d.chainDeferred(content_data["finished_d"])
else: