massive refactoring to switch from camelCase to snake_case:

historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.

However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.

To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.

This is a massive change, and may result in some bugs.
This commit is contained in:
Goffi 2023-04-08 13:54:42 +02:00
commit 6a6f15707a

View file

@ -46,7 +46,7 @@ class DirectorySubscription(object):
def __init__(self, host):
log.info(_("Directory subscription plugin initialization"))
self.host = host
host.importMenu(
host.import_menu(
(D_("Service"), D_("Directory subscription")),
self.subscribe,
security_limit=1,
@ -60,16 +60,16 @@ class DirectorySubscription(object):
@param profile (unicode): %(doc_profile)s
@return: a deferred dict{unicode: unicode}
"""
d = self.host.plugins["XEP-0055"]._getHostServices(profile)
d = self.host.plugins["XEP-0055"]._get_host_services(profile)
def got_services(services):
service_jid = services[0]
session_id, session_data = self.host.plugins[
"XEP-0050"
].requesting.newSession(profile=profile)
].requesting.new_session(profile=profile)
session_data["jid"] = service_jid
session_data["node"] = CMD_UPDATE_SUBSCRIBTION
data = {"session_id": session_id}
return self.host.plugins["XEP-0050"]._requestingEntity(data, profile)
return self.host.plugins["XEP-0050"]._requesting_entity(data, profile)
return d.addCallback(got_services)