erebion/libervia-backend
Watch
1
0
Fork
You've already forked libervia-backend
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

massive refactoring to switch from camelCase to snake_case:

Browse source 
historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.

However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.

To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.

This is a massive change, and may result in some bugs.
This commit is contained in:
Goffi 2023-04-08 13:54:42 +02:00
commit 6a6f15707a
1 changed files with 9945 additions and 9945 deletions
Download patch file Download diff file Expand all files Collapse all files

12
sat/plugins/plugin_misc_watched.py
View file

@ -61,25 +61,25 @@ class Watched(object):
def __init__(self, host):
log.info(_("Watched initialisation"))
self.host = host
host.memory.updateParams(self.params)
host.trigger.add("presence_received", self._presenceReceivedTrigger)
host.memory.update_params(self.params)
host.trigger.add("presence_received", self._presence_received_trigger)
def _presenceReceivedTrigger(self, client, entity, show, priority, statuses):
def _presence_received_trigger(self, client, entity, show, priority, statuses):
if show == C.PRESENCE_UNAVAILABLE:
return True
# we check that the previous presence was unavailable (no notification else)
try:
old_show = self.host.memory.getEntityDatum(
old_show = self.host.memory.get_entity_datum(
client, entity, "presence").show
except (KeyError, exceptions.UnknownEntityError):
old_show = C.PRESENCE_UNAVAILABLE
if old_show == C.PRESENCE_UNAVAILABLE:
watched = self.host.memory.getParamA(
watched = self.host.memory.param_get_a(
NAME, CATEGORY, profile_key=client.profile)
if entity in watched or entity.userhostJID() in watched:
self.host.actionNew(
self.host.action_new(
{
"xmlui": xml_tools.note(
_(NOTIF).format(entity=entity.full())