massive refactoring to switch from camelCase to snake_case:

historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.

However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.

To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.

This is a massive change, and may result in some bugs.
This commit is contained in:
Goffi 2023-04-08 13:54:42 +02:00
commit 6a6f15707a

View file

@ -65,9 +65,9 @@ class LangDetect(object):
def __init__(self, host):
log.info(_("Language detection plugin initialization"))
self.host = host
host.memory.updateParams(PARAMS)
host.trigger.add("messageReceived", self.messageReceivedTrigger)
host.trigger.add("sendMessage", self.MessageSendTrigger)
host.memory.update_params(PARAMS)
host.trigger.add("messageReceived", self.message_received_trigger)
host.trigger.add("sendMessage", self.message_send_trigger)
def add_language(self, mess_data):
message = mess_data["message"]
@ -78,18 +78,18 @@ class LangDetect(object):
mess_data["message"] = {lang: msg}
return mess_data
def messageReceivedTrigger(self, client, message_elt, post_treat):
def message_received_trigger(self, client, message_elt, post_treat):
""" Check if source is linked and repeat message, else do nothing """
lang_detect = self.host.memory.getParamA(
lang_detect = self.host.memory.param_get_a(
NAME, CATEGORY, profile_key=client.profile
)
if lang_detect:
post_treat.addCallback(self.add_language)
return True
def MessageSendTrigger(self, client, data, pre_xml_treatments, post_xml_treatments):
lang_detect = self.host.memory.getParamA(
def message_send_trigger(self, client, data, pre_xml_treatments, post_xml_treatments):
lang_detect = self.host.memory.param_get_a(
NAME, CATEGORY, profile_key=client.profile
)
if lang_detect: