erebion/libervia-backend
Watch
1
0
Fork
You've already forked libervia-backend
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

plugin XEP-0356: Fix incorrect _on_presence definition

Browse source
This commit is contained in:
Goffi 2026-05-04 16:20:35 +02:00
commit 351b7e2140
2 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
libervia/backend/plugins/plugin_xep_0356.py
View file

@ -514,7 +514,7 @@ class XEP_0356:
log.error(f"Invalid privileged IQ response: {iq_result_elt.toXml()}")
raise PrivilegeError("Invalid response format")
async def _on_presence(
def _on_presence(
self, presence_elt: domish.Element, client: SatXMPPComponent
) -> None:
defer.ensureDeferred(self.on_presence(presence_elt, client))

14
tests/unit/test_plugin_xep_0356.py
View file

@ -676,7 +676,7 @@ class TestXEP0356PresenceHandling:
G.host.trigger.async_point = mock_async_point
await xep_0356._on_presence(presence, client)
await xep_0356.on_presence(presence, client)
assert len(trigger_point_calls) == 1
point_name, args = trigger_point_calls[0]
@ -700,7 +700,7 @@ class TestXEP0356PresenceHandling:
G.host.trigger.async_point = mock_async_point
await xep_0356._on_presence(presence, client)
await xep_0356.on_presence(presence, client)
# We check that async_point was triggered
assert len(trigger_point_calls) == 1
@ -716,7 +716,7 @@ class TestXEP0356PresenceHandling:
presence_available = domish.Element((None, "presence"))
presence_available["from"] = "user@test.example/resource1"
await xep_0356._on_presence(presence_available, client)
await xep_0356.on_presence(presence_available, client)
assert bare_jid in data.presence_data.online_resources
assert "resource1" in data.presence_data.online_resources[bare_jid]
@ -724,7 +724,7 @@ class TestXEP0356PresenceHandling:
presence_unavailable = domish.Element((None, "presence"))
presence_unavailable["from"] = "user@test.example/resource1"
presence_unavailable["type"] = "unavailable"
await xep_0356._on_presence(presence_unavailable, client)
await xep_0356.on_presence(presence_unavailable, client)
assert bare_jid in data.presence_data.online_resources
assert "resource1" not in data.presence_data.online_resources[bare_jid]
@ -739,14 +739,14 @@ class TestXEP0356PresenceHandling:
presence1 = domish.Element((None, "presence"))
presence1["from"] = "user@test.example/resource1"
await xep_0356._on_presence(presence1, client)
await xep_0356.on_presence(presence1, client)
assert bare_jid in data.presence_data.online_resources
assert "resource1" in data.presence_data.online_resources[bare_jid]
presence2 = domish.Element((None, "presence"))
presence2["from"] = "user@test.example/resource2"
await xep_0356._on_presence(presence2, client)
await xep_0356.on_presence(presence2, client)
assert "resource1" in data.presence_data.online_resources[bare_jid]
assert "resource2" in data.presence_data.online_resources[bare_jid]
@ -762,6 +762,6 @@ class TestXEP0356PresenceHandling:
presence = domish.Element((None, "presence"))
presence["from"] = "user@test.example"
await xep_0356._on_presence(presence, client)
await xep_0356.on_presence(presence, client)
assert bare_jid not in data.presence_data.online_resources