From 1e327c01e1fd707cbf63fcf3662b9889d390fe21 Mon Sep 17 00:00:00 2001 From: Goffi Date: Fri, 12 Jul 2019 09:04:45 +0200 Subject: [PATCH] Backed out changeset cf0dda0d4cda check_output can't be used as it's waiting for command to return, blocking the edition. --- sat_frontends/jp/cmd_blog.py | 38 ++++++++++++++++-------------------- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/sat_frontends/jp/cmd_blog.py b/sat_frontends/jp/cmd_blog.py index 64e959fb..ee7cbc4c 100644 --- a/sat_frontends/jp/cmd_blog.py +++ b/sat_frontends/jp/cmd_blog.py @@ -514,27 +514,23 @@ class Edit(base.CommandBase, BlogPublishCommon, common.BaseEdit): # do we need a preview ? if self.args.preview: self.disp(u"Preview requested, launching it", 1) - # we redirect stderr to stdout and capture output to avoid console pollution - # in editor. - # If user wants to see messages, (s)he can call "blog preview" directly - try: - subprocess.check_output( - [ - sys.argv[0], - "blog", - "preview", - "--inotify", - "true", - "-p", - self.profile, - content_file_path, - ], - stderr=subprocess.STDOUT, - ) - except Exception as e: - self.disp(u"Can't show preview: {msg}".format( - msg=e.output.decode('utf-8'), err=True)) - sys.exit(e.returncode) + # we redirect outputs to /dev/null to avoid console pollution in editor + # if user wants to see messages, (s)he can call "blog preview" directly + DEVNULL = open(os.devnull, "wb") + subprocess.Popen( + [ + sys.argv[0], + "blog", + "preview", + "--inotify", + "true", + "-p", + self.profile, + content_file_path, + ], + stdout=DEVNULL, + stderr=subprocess.STDOUT, + ) # we launch editor self.runEditor(