From 0d214783a3b78b7ed704b63c5f39c64eec6edc38 Mon Sep 17 00:00:00 2001 From: Goffi Date: Tue, 25 Jan 2022 17:13:32 +0100 Subject: [PATCH] component file sharing: fix incorrect use of `returnValue` in `items` async method --- sat/plugins/plugin_comp_file_sharing.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sat/plugins/plugin_comp_file_sharing.py b/sat/plugins/plugin_comp_file_sharing.py index 3f4630a9..59ee6806 100644 --- a/sat/plugins/plugin_comp_file_sharing.py +++ b/sat/plugins/plugin_comp_file_sharing.py @@ -814,7 +814,7 @@ class Comments_handler(pubsub.PubSubService): continue def _getFrom(self, item_elt): - """retrieve published of an item + """retrieve publisher of an item @param item_elt(domish.element): element @return (unicode): full jid as string @@ -845,9 +845,7 @@ class Comments_handler(pubsub.PubSubService): file_data = await self.getFileData(requestor, nodeIdentifier) comments = file_data["extra"].get("comments", []) if itemIdentifiers: - defer.returnValue( - [generic.parseXml(c[2]) for c in comments if c[0] in itemIdentifiers] - ) + return [generic.parseXml(c[2]) for c in comments if c[0] in itemIdentifiers] else: return [generic.parseXml(c[2]) for c in comments]