From 07e8942ba928d624585162065bb0375e15119054 Mon Sep 17 00:00:00 2001 From: Goffi Date: Tue, 29 Sep 2015 20:19:43 +0200 Subject: [PATCH] plugins: lowered security limits for non dangerous actions. A reference documentation is in progress to choose values: http://wiki.goffi.org/wiki/Security_Limits/en --- src/plugins/plugin_xep_0050.py | 4 ++-- src/plugins/plugin_xep_0100.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/plugin_xep_0050.py b/src/plugins/plugin_xep_0050.py index 5f83f16d..44ef1b2b 100644 --- a/src/plugins/plugin_xep_0050.py +++ b/src/plugins/plugin_xep_0050.py @@ -219,7 +219,7 @@ class XEP_0050(object): method=self._requestCommandsList, async=True) self.__requesting_id = host.registerCallback(self._requestingEntity, with_data=True) - host.importMenu((D_("Service"), D_("commands")), self._commandsMenu, security_limit=4, help_string=D_("Execute ad-hoc commands")) + host.importMenu((D_("Service"), D_("commands")), self._commandsMenu, security_limit=2, help_string=D_("Execute ad-hoc commands")) def getHandler(self, profile): return XEP_0050_handler(self) @@ -401,7 +401,7 @@ class XEP_0050(object): form_ui.addText(_("Please enter target jid"), 'instructions') form_ui.changeContainer("pairs") form_ui.addLabel("jid") - jid = form_ui.addString("jid", value=self.host.getClient(profile).jid.host) + form_ui.addString("jid", value=self.host.getClient(profile).jid.host) return {'xmlui': form_ui.toXml()} def _statusCallback(self, command_elt, session_data, action, node, profile): diff --git a/src/plugins/plugin_xep_0100.py b/src/plugins/plugin_xep_0100.py index 1b03f37e..18bbcccd 100755 --- a/src/plugins/plugin_xep_0100.py +++ b/src/plugins/plugin_xep_0100.py @@ -63,7 +63,7 @@ class XEP_0100(object): host.bridge.addMethod("gatewayRegister", ".plugin", in_sign='ss', out_sign='s', method=self._gatewayRegister) self.__menu_id = host.registerCallback(self._gatewaysMenu, with_data=True) self.__selected_id = host.registerCallback(self._gatewaySelectedCb, with_data=True) - host.importMenu((D_("Service"), D_("gateways")), self._gatewaysMenu, security_limit=2, help_string=D_("Find gateways")) + host.importMenu((D_("Service"), D_("gateways")), self._gatewaysMenu, security_limit=1, help_string=D_("Find gateways")) def _gatewaysMenu(self, data, profile): """ XMLUI activated by menu: return Gateways UI