coreboot

History

Nicholas Chin 94247e93a2 util/find_usbdebug: Fix lsusb -t parsing for usbutils v016 and newer Commit e24294ff9ade ("lsusb -t: print ports and busses and devices with same width") [1] in the usbutils repository changed the format of the lsusb -t output, breaking the find_usbdebug.sh script. This commit is present in usbutils version 016 and later. Use the output of lsusb -V to set the parsing patterns based on the version in order to maintain compatibility with older versions of usbutils. A simple integer comparison of the version number is used for this, which will not work with versions older than v001 as those use a 0.nn version number format. However, since v001 was released in late 2010, it is probably safe to assume that no one will be using a version of usbutils older than that. Usbutils v016 was released in late 2023 so there could still conceivably be systems using older versions, such as Ubuntu 22.04 LTS which is on v014. TEST=find_usbdebug.sh works as expected with both lsusb v015 and v017 [1] `e24294ff9a` Change-Id: Iffa1238b995d387d6e51459f85ae96da52a5c0ff Signed-off-by: Nicholas Chin <nic.c3.14@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85790 Reviewed-by: Jan Philipp Groß <jeangrande@mailbox.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>	2025-01-17 05:55:53 +00:00
..
description.md	util: Update description files	2022-05-30 13:05:21 +00:00
find_usbdebug.sh	util/find_usbdebug: Fix lsusb -t parsing for usbutils v016 and newer	2025-01-17 05:55:53 +00:00

Nicholas Chin 94247e93a2 util/find_usbdebug: Fix lsusb -t parsing for usbutils v016 and newer

Commit e24294ff9ade ("lsusb -t: print ports and busses and devices with
same width") [1] in the usbutils repository changed the format of the
lsusb -t output, breaking the find_usbdebug.sh script. This commit is
present in usbutils version 016 and later.

Use the output of lsusb -V to set the parsing patterns based on the
version in order to maintain compatibility with older versions of
usbutils. A simple integer comparison of the version number is used for
this, which will not work with versions older than v001 as those use a
0.nn version number format. However, since v001 was released in late
2010, it is probably safe to assume that no one will be using a version
of usbutils older than that. Usbutils v016 was released in late 2023 so
there could still conceivably be systems using older versions, such as
Ubuntu 22.04 LTS which is on v014.

TEST=find_usbdebug.sh works as expected with both lsusb v015 and v017

[1] e24294ff9a

Change-Id: Iffa1238b995d387d6e51459f85ae96da52a5c0ff
Signed-off-by: Nicholas Chin <nic.c3.14@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85790
Reviewed-by: Jan Philipp Groß <jeangrande@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>

2025-01-17 05:55:53 +00:00

description.md util: Update description files 2022-05-30 13:05:21 +00:00

find_usbdebug.sh util/find_usbdebug: Fix lsusb -t parsing for usbutils v016 and newer 2025-01-17 05:55:53 +00:00