At a process _start, the stack is expected to be aligned to a 16-byte boundary. Upon entry to any function the stack frame must have the end of any arguments also aligned. In other words the value of %esp+4 or %rsp+8 is always a multiple of 16 (1). Align the stack down inside _secondary_start and preserve proper alignment for the call to secondary_cpu_init. Although 4-byte alignment is the minimum requirement for i386, some AMD platforms use SSE instructions which expect 16-byte. 1) http://wiki.osdev.org/System_V_ABI See "Initial Stack and Register State" and "The Stack Frame" in the supplements. BUG=chrome-os-partner:62841664 Change-Id: I72b7a474013e5caf67aedfabeb8d8d2553499b73 Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com> Reviewed-on: https://review.coreboot.org/20537 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> |
||
|---|---|---|
| .. | ||
| 16bit | ||
| 32bit | ||
| cache | ||
| lapic | ||
| mtrr | ||
| name | ||
| pae | ||
| smm | ||
| tsc | ||
| backup_default_smm.c | ||
| car.c | ||
| fpu_enable.inc | ||
| Kconfig | ||
| Makefile.inc | ||
| mirror_payload.c | ||
| mp_init.c | ||
| sipi_vector.S | ||
| sse_enable.inc | ||