coreboot/src/include/console
Lee Leahy f00e446e74 src/include: Add parenthesis around macros
Fix the following error found by checkpatch.pl:

ERROR: Macros with complex values should be enclosed in parentheses

False positives are detected for attribute macros.  An example is:

ERROR: Macros with complex values should be enclosed in parentheses
+#define BOOT_STATE_INIT_ATTR  __attribute__ ((used, section
(".bs_init")))

False positive also generated for macros for linker script files.  An
example is:

ERROR: Macros with complex values should be enclosed in parentheses
+#define CBFS_CACHE(addr, size) \
+	REGION(cbfs_cache, addr, size, 4) \
+	ALIAS_REGION(cbfs_cache, preram_cbfs_cache) \
+	ALIAS_REGION(cbfs_cache, postram_cbfs_cache)

False positives generated for assembly code macros.  An example is:

ERROR: Macros with complex values should be enclosed in parentheses
+#define DECLARE_OPTIONAL_REGION(name) asm (".weak _" #name ", _e" #name
)

False positive detected when macro includes multiple comma separated
values.  The following code is from src/include/device/azalia_device.h:

#define AZALIA_SUBVENDOR(codec, val)		    \
	(((codec) << 28) | (0x01720 << 8) | ((val) & 0xff)),	\
	(((codec) << 28) | (0x01721 << 8) | (((val) >> 8) & 0xff)), \
	(((codec) << 28) | (0x01722 << 8) | (((val) >> 16) & 0xff)), \
	(((codec) << 28) | (0x01723 << 8) | (((val) >> 24) & 0xff))

TEST=Build and run on Galileo Gen2

Change-Id: I6e3b6950738e6906851a172ba3a22e3d5af1e35d
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18649
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
2017-03-10 22:28:35 +01:00
..
cbmem_console.h src/include: Add parenthesis around macros 2017-03-10 22:28:35 +01:00
console.h console: Enable printk for ENV_LIBAGESA 2017-03-07 00:43:49 +01:00
early_print.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
ne2k.h header files: Fix guard name comments to match guard names 2016-01-18 04:07:53 +01:00
post_codes.h drivers/intel/fsp2_0: track end of firmware notifications 2016-11-12 04:07:06 +01:00
qemu_debugcon.h console: Simplify the enable rules 2014-04-18 16:41:09 +02:00
spi.h src/include: Add parenthesis around macros 2017-03-10 22:28:35 +01:00
spkmodem.h console: Simplify the enable rules 2014-04-18 16:41:09 +02:00
streams.h console: Add write line routine 2016-08-10 22:30:19 +02:00
uart.h src/include: Add parenthesis around macros 2017-03-10 22:28:35 +01:00
usb.h src/include: Add parenthesis around macros 2017-03-10 22:28:35 +01:00
vtxprintf.h src/include: Add space after comma 2017-03-09 17:19:16 +01:00