coreboot/util/cbfstool
Julius Werner 06e3dcac45 cbfs: Remove broken remnants of PAYLOAD_INFO feature
PAYLOAD_INFO is a very old feature that can add a key/value information
section to a payload file. It seems to have only ever been generated by
coreinfo and never really read by anything.

Since CB:1721 in 2012, the feature has been inadvertently broken in
practice since the `.note.pinfo` sections that contain the information
get discarded from the payload before cbfstool gets to see them. Since
CB:28647 in 2018, support for the section in the SELF loader was
(inadvertently?) dropped, so if someone actually fed cbfstool a payload
ELF that did have a `.note.pinfo` section, modern coreboot would refuse
to boot the payload entirely (which is probably not a good state to
leave things in).

This patch removes the code to generate PAYLOAD_INFO entries entirely,
but leaves the support to parse and extract those sections from old
payloads in place in cbfstool.

Change-Id: I40d8e9b76a171ebcdaa2eae02d54a1ca5e592c85
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81087
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
2024-03-13 18:51:11 +00:00
..
bpdt_formats
console
flashmap
fpt_formats
lz4
lzma
tests
.gitignore
amdcompress.c
cbfs-mkpayload.c cbfs: Remove broken remnants of PAYLOAD_INFO feature 2024-03-13 18:51:11 +00:00
cbfs-mkstage.c
cbfs-payload-linux.c
cbfs.h
cbfs_glue.h
cbfs_image.c cbfs: Remove broken remnants of PAYLOAD_INFO feature 2024-03-13 18:51:11 +00:00
cbfs_image.h
cbfs_sections.c
cbfs_sections.h
cbfscomptool.c
cbfstool.c
coff.h
common.c
common.h
compress.c
cse_fpt.c
cse_fpt.h
cse_helpers.c
cse_helpers.h
cse_serger.c
cse_serger.h
default-x86.fmd
default.fmd
description.md
elf.h
elfheaders.c
elfparsing.h
elogtool.c
eventlog.c
eventlog.h
EXAMPLE
fdt.h
fit.c
fit.h
flashmap_tests.c
flashrom.c
flashrom.h
fmap_from_fmd.c
fmap_from_fmd.h
fmaptool.c
fmd.c
fmd.h
fmd_parser.c_shipped
fmd_parser.h_shipped
fmd_parser.y
fmd_scanner.c_shipped
fmd_scanner.h_shipped
fmd_scanner.l
fv.h
ifittool.c
ifwitool.c
linux.h
linux_trampoline.c
linux_trampoline.h
linux_trampoline.S
Makefile
Makefile.mk
option.h
partitioned_file.c
partitioned_file.h
platform_fixups.c
ProcessorBind.h
rmodtool.c
rmodule.c
rmodule.h
xdr.c