This patch adds a new test to checkpatch that identifies cases where a line after a conditional statement is incorrectly intended (possibly indicating the mistake of forgetting to add braces), like this: if (a) b; c; Unfortunately, it seems like checkpatch is partially unmaintained in upstream Linux at the moment with maintainers either not responding at all or not even willing to look at new patches [1]. Since detecting this error class is important to coreboot, let's just carry this feature locally for now. [1] https://lkml.org/lkml/2021/4/15/1488 Signed-off-by: Julius Werner <jwerner@chromium.org> Change-Id: I7bb90b56dfc7582271d2b82cb42a2c1df477054f Reviewed-on: https://review.coreboot.org/c/coreboot/+/51838 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Nico Huber <nico.h@gmx.de> |
||
|---|---|---|
| .. | ||
| check-style | ||
| check_lint_tests | ||
| checkpatch.pl | ||
| checkpatch_json.py | ||
| const_structs.checkpatch | ||
| description.md | ||
| kconfig_lint | ||
| kconfig_lint_README | ||
| lint | ||
| lint-000-license-headers | ||
| lint-001-no-global-config-in-romstage | ||
| lint-007-checkpatch | ||
| lint-008-kconfig | ||
| lint-014-qualified-types | ||
| lint-extended-007-checkpatch | ||
| lint-extended-015-final-newlines | ||
| lint-extended-020-signed-off-by | ||
| lint-stable-000-license-headers | ||
| lint-stable-003-whitespace | ||
| lint-stable-004-style-labels | ||
| lint-stable-005-board-status | ||
| lint-stable-006-board-name | ||
| lint-stable-008-kconfig | ||
| lint-stable-009-old-licenses | ||
| lint-stable-010-asm-syntax | ||
| lint-stable-012-executable-bit | ||
| lint-stable-013-site-local | ||
| lint-stable-016-non-ascii | ||
| lint-stable-017-configs | ||
| lint-stable-018-symlinks | ||
| lint-stable-019-header-files | ||
| lint-stable-021-coreboot-lowercase | ||
| lint-stable-022-clang-format | ||
| lint-stable-023-filenames | ||
| lint-stable-024-kconfig-no-subsystem | ||
| lint-stable-026-line-endings | ||
| lint-stable-027-maintainers-syntax | ||
| remccoms3.sed | ||
| spelling.txt | ||