f2cf732997
Disks larger than 2TB (technically disks with more than 2^32 blocks, but for the common block size of 512 that comes out to 2TB) cannot represent their full amount of blocks in the SCSI READ_CAPACITY(10) command used by libpayload's USB mass storage driver. The entire driver isn't written to support block addresses larger than 32 bits anyway. The SCSI command has been designed in a clever way so that devices are supposed to return the maximum value (0xffffffff) if the actual value doesn't fit. However, our code adds one to the value (because it is actually the address of the last block, but we want to know the number of blocks). This makes it overflow back to 0 which is not great. This patch caps the result before incrementing it so that the overflow cannot occur, allowing us to at least access the first 2TB of super large USB sticks. Change-Id: Ic445923b7d588c4f523c4ed95a06291bc1969261 Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87506 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Yu-Ping Wu <yupingso@google.com> |
||
|---|---|---|
| .. | ||
| i8042 | ||
| serial | ||
| storage | ||
| timer | ||
| udc | ||
| usb | ||
| video | ||
| cbmem_console.c | ||
| hid.c | ||
| Makefile.mk | ||
| mouse_cursor.c | ||
| nvram.c | ||
| options.c | ||
| pci_io_ops.c | ||
| pci_map_bus_ops.c | ||
| pci_ops.c | ||
| pci_qcom.c | ||
| pcie_mediatek.c | ||
| speaker.c | ||