The `chars` pointer references the heap which is part of the payload and relocated along with it. So calling phys_to_virt() on it was always wrong; and the virt_to_phys() at its initialization was a no-op anyway, when the console was brought up before relocation. While we are at it, add a null-pointer check. Change-Id: Ic03150f0bcd14a6ec6bf514dffe2b9153d5a6d2a Signed-off-by: Nico Huber <nico.huber@secunet.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/38536 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Julius Werner <jwerner@chromium.org> |
||
|---|---|---|
| .. | ||
| i8042 | ||
| serial | ||
| storage | ||
| timer | ||
| udc | ||
| usb | ||
| video | ||
| cbmem_console.c | ||
| hid.c | ||
| Makefile.inc | ||
| mouse_cursor.c | ||
| nvram.c | ||
| options.c | ||
| pci.c | ||
| speaker.c | ||