erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
coreboot/src/mainboard
History
Nicholas Sudsgaard bfb11bec3b include/device/device.h: Remove CHIP_NAME() macro 
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:

CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,

This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.

It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.

Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
2024-01-31 09:51:58 +00:00
..
51nb mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
acer mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
adlink
amd soc/amd: use common ACPI_SCI_IRQ definition 2024-01-27 16:39:21 +00:00
aopen mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
apple mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
asrock mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
asus mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
biostar mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
bostentech mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
bytedance mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
cavium src, util: Clean up makefile.inc in text, help & comments 2024-01-26 20:15:18 +00:00
clevo mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
compulab mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
dell mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
emulation include/device/device.h: Remove CHIP_NAME() macro 2024-01-31 09:51:58 +00:00
example
facebook mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
foxconn mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
getac mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
gigabyte mb/51nb to mb/gigabyte: Rename Makefiles from .inc to .mk 2024-01-24 10:17:55 +00:00
google mb/google/brya: Correct Ti50 EC-is-trusted logic 2024-01-31 06:03:27 +00:00
hp mb/hp/snb_ivb_laptops: Add SMBIOS slot information 2024-01-25 14:53:29 +00:00
ibase mb/hp to mb/kontron: Rename Makefiles from .inc to .mk 2024-01-24 11:54:31 +00:00
ibm mb/hp to mb/kontron: Rename Makefiles from .inc to .mk 2024-01-24 11:54:31 +00:00
intel src, util: Clean up makefile.inc in text, help & comments 2024-01-26 20:15:18 +00:00
inventec mb/hp to mb/kontron: Rename Makefiles from .inc to .mk 2024-01-24 11:54:31 +00:00
kontron mb/hp to mb/kontron: Rename Makefiles from .inc to .mk 2024-01-24 11:54:31 +00:00
lenovo mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
libretrend mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
msi mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
ocp mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
opencellular src, util: Clean up makefile.inc in text, help & comments 2024-01-26 20:15:18 +00:00
packardbell mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
pcengines mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
pine64 mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
portwell mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
prodrive mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
protectli src, util: Clean up makefile.inc in text, help & comments 2024-01-26 20:15:18 +00:00
purism mb/purism/librem_cnl: Set edk2 boot timeout for Librem Mini 2024-01-26 15:11:21 +00:00
razer mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
roda mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
samsung mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
sapphire mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
siemens mb/siemens/mc_ehl3: Use PSE GbE 0 instead of PSE GbE 1 2024-01-27 14:20:01 +00:00
sifive mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
starlabs mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
supermicro include/device/device.h: Remove CHIP_NAME() macro 2024-01-31 09:51:58 +00:00
system76 mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
ti mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
up mb/lenovo to mb/squared: Rename Makefiles from .inc to .mk 2024-01-24 11:54:40 +00:00
Kconfig mainboard/Kconfig: add 24MB ROM size 2024-01-22 12:15:11 +00:00