erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
coreboot/util/amdfwtool
History
Arthur Heymans a7eb390796 mb/*/*/*.fmd: Start flash at 0 
FMAP should not contain information about the memory map.

Done with the following command:
"find -name \*.fmd -exec sed -i 's/\(FLASH\).* \(.*\) /\1 \2 /' {} \;"

for AMD:
All addresses that amdfwtool expects as command line parameter have the
ADDR_REL_BIOS (flash address) address_mode setting. One exception is
the *_FW_A_POSITION and *_FW_B_POSITION addresses. But amdfwtool checks
if memory or flash addresses are passed and converts accordingly. So
changing the address from memory -> flash doesn't matter for the
resulting binary.
Since commit 41a162b7a8 ("soc/amd/phoenix/Makefile.inc: Pass APOB_NV
address as offset") and therefore since phoenix SOC, APOB_NV is passed
as flash offset. But before that the memory ABL always assumed a MMIO
address (no matter the address_mode) so we need to add a little quirk
for that.

tested: boot glinda based mainboard and also check that memory training
is still cached successfully in APOB_NV.

Change-Id: Iac86ef9be6b14817a65bf3a7ccb624d205ca3f99
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Signed-off-by: Maximilian Brune <maximilian.brune@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63771
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Shuo Liu <shuo.liu@intel.com>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
2025-04-09 17:11:43 +00:00
..
.gitignore
amdfwread.c mb/*/*/*.fmd: Start flash at 0 2025-04-09 17:11:43 +00:00
amdfwtool.c util/amdfwtool: add PLATFORM_FAEGAN 2025-04-02 16:02:47 +00:00
amdfwtool.h mb/*/*/*.fmd: Start flash at 0 2025-04-09 17:11:43 +00:00
data_parse.c mb/*/*/*.fmd: Start flash at 0 2025-04-09 17:11:43 +00:00
description.md
handle_file.c amdfwtool: Move the functions to handle_file.c 2024-03-04 14:50:53 +00:00
Makefile amdfwtool: Use Makefile.mk for Makefile settings 2024-02-29 02:24:09 +00:00
Makefile.mk amdfwtool: Move code related to getting options to a new file 2024-03-06 11:05:07 +00:00
opts.c mb/*/*/*.fmd: Start flash at 0 2025-04-09 17:11:43 +00:00
signed_psp.c util/amdfwtool: add PLATFORM_FAEGAN 2025-04-02 16:02:47 +00:00