Current log2_ceil(x) is defined as log2(x * 2 - 1). When x is larger than (1 << 31), (x * 2 - 1) won't fit in u32, leading to incorrect result. Therefore, correct it as (log2(x - 1) + 1). Also add unit tests for inline functions in lib.h. BUG=none TEST=make tests/lib/lib-test BRANCH=none Change-Id: If868f793b909a6ad7fc48a7affac15e2c714fa2e Signed-off-by: Yu-Ping Wu <yupingso@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/59834 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Paul Menzel <paulepanter@mailbox.org> |
||
|---|---|---|
| .. | ||
| b64_decode-test.c | ||
| bootmem-test.c | ||
| cbfs-lookup-test.c | ||
| cbfs-verification-test.c | ||
| cbmem_console-test.c | ||
| cbmem_stage_cache-test.c | ||
| compute_ip_checksum-test.c | ||
| coreboot_table-test.c | ||
| crc_byte-test.c | ||
| dimm_info_util-test.c | ||
| edid-test.c | ||
| fmap-test.c | ||
| hexstrtobin-test.c | ||
| imd-test.c | ||
| imd_cbmem-test.c | ||
| lib-test.c | ||
| libgcc-test.c | ||
| list-test.c | ||
| lzma-test.c | ||
| Makefile.inc | ||
| malloc-test.c | ||
| memchr-test.c | ||
| memcmp-test.c | ||
| memcpy-test.c | ||
| memmove-test.c | ||
| memrange-test.c | ||
| memset-test.c | ||
| region_file-test.c | ||
| rtc-test.c | ||
| spd_cache-test.c | ||
| stack-test.c | ||
| string-test.c | ||
| timestamp-test.c | ||
| uuid-test.c | ||