erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
coreboot/src/soc
History
Martin Roth b268d78f2a UPSTREAM: soc/marvell/mvmap2315: Mark mvmap2315_reset() as noreturn 
mvmap2315_reset() is called from locations where we're checking for NULL
pointers.  Because coverity can't tell from the code that the functions
are not returning, it's showing errors of accessing pointers after
we've determined that they're invalid.

Mark it as noreturn, and add a loop in case the reset isn't on the
next instruction.  This probably isn't needed, but shouldn't hurt.

BUG=none
BRANCH=none
TEST=none

Change-Id: Icabde50124ed8206a0a114cd10002ef81a770f57
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 3051cd9265
Original-Found-by: Coverity Scan #1362809
Original-Change-Id: If93084629d5c2c8dc232558f2559b78b1ca5de7c
Original-Signed-off-by: Martin Roth <martinroth@google.com>
Original-Reviewed-on: https://review.coreboot.org/18103
Original-Tested-by: build bot (Jenkins)
Original-Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Original-Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://chromium-review.googlesource.com/428257
Commit-Ready: Aaron Durbin <adurbin@chromium.org>
2017-01-13 18:41:29 -08:00
..
broadcom/cygnus UPSTREAM: spi: Get rid of SPI_ATOMIC_SEQUENCING 2017-01-05 11:00:04 -08:00
dmp/vortex86ex UPSTREAM: src/soc: Capitalize CPU, ACPI, RAM and ROM 2016-08-04 23:37:59 -07:00
imgtec/pistachio UPSTREAM: spi: Get rid of SPI_ATOMIC_SEQUENCING 2017-01-05 11:00:04 -08:00
intel UPSTREAM: fsp 1.0 systems: Check for NULL when saving HobListPtr 2017-01-13 18:41:17 -08:00
lowrisc/lowrisc UPSTREAM: soc/lowrisc: Place CBMEM at top of autodetected RAM 2016-12-08 12:30:55 -08:00
marvell UPSTREAM: soc/marvell/mvmap2315: Mark mvmap2315_reset() as noreturn 2017-01-13 18:41:29 -08:00
mediatek/mt8173 UPSTREAM: spi: Get rid of SPI_ATOMIC_SEQUENCING 2017-01-05 11:00:04 -08:00
nvidia UPSTREAM: spi: Define and use spi_ctrlr structure 2016-12-08 12:30:16 -08:00
qualcomm UPSTREAM: spi: Get rid of SPI_ATOMIC_SEQUENCING 2017-01-05 11:00:04 -08:00
rdc/r8610 rdc/r8610: Move to src/soc 2016-05-05 20:08:58 +02:00
rockchip Cherry-pick: rk3288: rtc-rk808: fix rtc time reading issue 2017-01-12 04:51:10 -08:00
samsung UPSTREAM: samsung/exynos5420: Fix test for src < 0 2016-12-16 15:42:11 -08:00
ucb/riscv UPSTREAM: soc/ucb/riscv: Place CBMEM at top of autodetected RAM 2016-12-08 12:30:48 -08:00