coreboot/src/soc/amd
Matt DeVillier b1e1b2ce08 soc/amd/common/block/gfx: Re-add signature check for vbios cache
Commit c7b8809f155a ("soc/amd/common/block/gfx: Use TPM-stored hash
for vbios cache validation") replaced checking the vbios signature
(first two bytes) with checking against a TPM-stored hash, but there
exists an edge case where the empty cache can be hashed and therefore
never updated with the correct vbios data. To mitigate this, re-add
the signature check to ensure that an empty cache will never be hashed
to TPM.

BUG=b:255812886

BRANCH=skyrim

TEST=build/boot skyrim w/selective GOP enabled, flash full firmware
image, ensure GOP driver is run until cache updated with valid data
and hashed to TPM.

Change-Id: Id06a8cfaa44d346fb2eece53dcf74ee46f4a5352
Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74525
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
2023-04-26 17:11:14 +00:00
..
cezanne soc/amd: Use ACPI_COMMON_MADT_IOAPIC 2023-04-26 11:05:09 +00:00
common soc/amd/common/block/gfx: Re-add signature check for vbios cache 2023-04-26 17:11:14 +00:00
glinda soc/amd: Use ACPI_COMMON_MADT_IOAPIC 2023-04-26 11:05:09 +00:00
mendocino soc/amd: Use ACPI_COMMON_MADT_IOAPIC 2023-04-26 11:05:09 +00:00
phoenix soc/amd/phoenix/Kconfig: Update comment 2023-04-26 12:04:58 +00:00
picasso soc/amd: Use ACPI_COMMON_MADT_IOAPIC 2023-04-26 11:05:09 +00:00
stoneyridge soc/amd: Use ACPI_COMMON_MADT_IOAPIC 2023-04-26 11:05:09 +00:00