37513297d3
Our mechanism to override the default (pure C) memory function implementations (memset, memcpy, memmove) with architecture-specific optimized assembly versions doesn't actually work: it turns out that weak functions don't work as you'd naively expect when you pack them together with a strong definition from a different object into a static library. When a linker tries to resolve a symbol from a static library, it just picks the first one it finds, even if it is weak. It doesn't evaluate all objects in the library to see if there are other strong definitions. To fix this, this patch gets rid of the weak symbols and uses Kconfigs instead. It adds an optimized memmove() implementation for x86 because that makes things easier (then all architectures either override all three functions or none of them). Also remove memcmp() from the functions that can be overridden for now because nobody ever needed that anyway. Change-Id: Iedf9898247f1999e56fde3233fad8b7cb36b1269 Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/87766 Reviewed-by: Yu-Ping Wu <yupingso@google.com> Reviewed-by: Subrata Banik <subratabanik@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
93 lines
3.3 KiB
C
93 lines
3.3 KiB
C
/*
|
|
*
|
|
* Copyright (C) 2008 Advanced Micro Devices, Inc.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. The name of the author may not be used to endorse or promote products
|
|
* derived from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef _STRING_H
|
|
#define _STRING_H
|
|
|
|
#include <commonlib/bsd/string.h>
|
|
#include <stddef.h>
|
|
|
|
/**
|
|
* @defgroup memory Memory manipulation functions
|
|
* @{
|
|
*/
|
|
void *memset(void *s, int c, size_t n);
|
|
void *memcpy(void *dst, const void *src, size_t n);
|
|
void *memmove(void *dst, const void *src, size_t n);
|
|
void *memchr(const void *s, int c, size_t n);
|
|
int memcmp(const void *s1, const void *s2, size_t len);
|
|
/** @} */
|
|
|
|
/**
|
|
* @defgroup default memory functions remain available under separate names, in
|
|
* case architecture implementations want to fall back to them in certain cases.
|
|
*/
|
|
void *default_memset(void *s, int c, size_t n);
|
|
void *default_memcpy(void *dst, const void *src, size_t n);
|
|
void *default_memmove(void *dst, const void *src, size_t n);
|
|
/** @} */
|
|
|
|
/**
|
|
* @defgroup string String functions
|
|
* @{
|
|
*/
|
|
int strcmp(const char *s1, const char *s2);
|
|
int strncmp(const char *s1, const char *s2, size_t maxlen);
|
|
int strcasecmp(const char *s1, const char *s2);
|
|
int strncasecmp(const char *s1, const char *s2, size_t maxlen);
|
|
char *strncpy(char *d, const char *s, size_t n);
|
|
char *strcpy(char *d, const char *s);
|
|
char *strchr(const char *s, int c);
|
|
char *strrchr(const char *s, int c);
|
|
char *strdup(const char *s);
|
|
char *strndup(const char *s, size_t size);
|
|
char *strstr(const char *h, const char *n);
|
|
char *strsep(char **stringp, const char *delim);
|
|
size_t strspn(const char *s, const char *a);
|
|
size_t strcspn(const char *s, const char *a);
|
|
char *strtok(char *str, const char *delim);
|
|
char *strtok_r(char *str, const char *delim, char **ptr);
|
|
char *strerror(int errnum);
|
|
/** @} */
|
|
|
|
/**
|
|
* @defgroup string Unicode functions
|
|
* @{
|
|
*/
|
|
char *utf16le_to_ascii(const uint16_t *utf16_string, size_t maxlen);
|
|
/** @} */
|
|
|
|
/**
|
|
* @defgroup string OpenBSD based safe string functions
|
|
* @{
|
|
*/
|
|
size_t strlcpy(char *d, const char *s, size_t n);
|
|
size_t strlcat(char *d, const char *s, size_t n);
|
|
/** @} */
|
|
|
|
#endif
|