coreboot/src/vendorcode
Duncan Laurie 643daed6b5 vendorcode/google/chromeos: Use explicit zero check in ACPI code
The ASL 2.0 syntax for "!X" resolves to "LNot(X)" which will evaluate
the object as an integer and turn into a boolean.  This may not do the
right thing if the object is actually a string and it can lead to
unexpected behavior.

Instead be specific about the object type and check for zero or an
empty string depending on what is being returned.

This fixes an issue where some VPD keys were causing the search to
stop and miss subsequent entries.

Change-Id: I1688842964f9c2f81ca31073da9c2d71a8c81767
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32694
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
2019-05-09 15:34:53 +00:00
..
amd Fix code that would trip -Wtype-limits 2019-05-06 10:32:15 +00:00
cavium vendorcode/cavium/bdk/libdram: Add missing comma 2019-03-25 10:59:30 +00:00
google vendorcode/google/chromeos: Use explicit zero check in ACPI code 2019-05-09 15:34:53 +00:00
intel Make common macros double-evaluation safe 2019-04-04 19:38:31 +00:00
siemens device/mmio.h: Add include file for MMIO ops 2019-03-04 15:57:39 +00:00
Makefile.inc soc/cavium: Integrate BDK files into coreboot 2018-07-03 15:53:32 +00:00