coreboot/src/security/vboot
Sridhar Siricilla d13a57915d security/vboot: Drop assert call from vbnv_udc_enable_flag()
It's true that vbnv_udc_enable_flag() is called after vbnv_init()
(that's why the assertion was added). However, the former is called in
the ramstage, while the latter in verstage. This means that
vbnv_initialized will be false in ramstage, which leads
to the assertion failure:

[EMERG]  ASSERTION ERROR: file 'src/security/vboot/vbnv.c', line 88

Since the ctx->nvdata will be restored in ramstage (by vb2api_reinit()),
simply remove the assertion. So, the patch drops assert call from
vbnv_udc_enable_flag() function.

TEST=Verify Rex system boots to OS without assert error.

Signed-off-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Change-Id: I49022155239febd5c5be5cf2c5eca2019ca61c12
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71097
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
2022-12-21 18:52:50 +00:00
..
antirollback.h security/vboot: Add rollback NVRAM space for TPM 2 2022-09-17 01:42:11 +00:00
bootmode.c Reland "vboot_logic: Set VB2_CONTEXT_EC_TRUSTED in verstage_main" 2021-11-15 12:00:12 +00:00
common.c vboot: Add VBOOT_CBFS_INTEGRATION support 2022-11-08 23:03:49 +00:00
ec_sync.c ec/google/chromeec: Deprecate dev_index from google_chromeec_reboot 2022-11-12 23:01:47 +00:00
Kconfig vboot: Force config file inclusion with CBFS integration 2022-12-07 02:38:50 +00:00
Makefile.inc vboot: Add VBOOT_CBFS_INTEGRATION support 2022-11-08 23:03:49 +00:00
misc.h cbfs/vboot: Adapt to new vb2_digest API 2022-09-02 23:51:29 +00:00
mrc_cache_hash_tpm.c cbfs/vboot: Adapt to new vb2_digest API 2022-09-02 23:51:29 +00:00
mrc_cache_hash_tpm.h security/vboot: Make mrc_cache hash functions generic 2020-10-20 23:25:39 +00:00
secdata_mock.c tpm: Refactor TPM Kconfig dimensions 2022-04-21 23:07:20 +00:00
secdata_tpm.c /: Remove extra space after comma 2022-11-30 03:07:23 +00:00
symbols.h treewide: Remove "this file is part of" lines 2020-05-11 17:11:40 +00:00
tpm_common.c cbfs/vboot: Adapt to new vb2_digest API 2022-09-02 23:51:29 +00:00
tpm_common.h Add Kconfig TPM 2021-05-26 12:31:10 +00:00
vbnv.c security/vboot: Drop assert call from vbnv_udc_enable_flag() 2022-12-21 18:52:50 +00:00
vbnv.h security/vboot: Update vbnv_init signature 2022-12-16 01:23:03 +00:00
vbnv_cmos.c coreboot_table: Move VBOOT_VBNV support 2021-02-04 08:43:39 +00:00
vbnv_flash.c treewide: Remove "this file is part of" lines 2020-05-11 17:11:40 +00:00
vbnv_layout.h treewide: Remove "this file is part of" lines 2020-05-11 17:11:40 +00:00
vboot_common.c vboot/vboot_common: Fix vboot_save_data() code exclusion guard 2022-12-01 22:12:10 +00:00
vboot_common.h vboot: Introduce handy vboot reboot functions 2022-11-08 14:44:54 +00:00
vboot_lib.c src: Change BOOL CONFIG_ to CONFIG() in comments & strings 2020-07-26 21:20:30 +00:00
vboot_loader.c vboot: Add VBOOT_CBFS_INTEGRATION support 2022-11-08 23:03:49 +00:00
vboot_logic.c security/vboot: Update vbnv_init signature 2022-12-16 01:23:03 +00:00
verstage.c verstage: Add debug print when returning from verstage 2021-04-06 07:49:43 +00:00