erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
coreboot/src/include/acpi
History
Jeremy Compostella 74f5a3e8a0 soc/intel: Improve CONFIG_ACPI_SOC_INTEL_SLP_S0_FREQ_HZ use 
Commit bd9c562a9e ("acpi: Configure
slp-s0 residency counter frequency in LPIT table") led to jenkins
reporting the following error:

    !!!!! Error: defined(CONFIG_ACPI_SOC_INTEL_SLP_S0_FREQ_HZ)
          used at src/include/acpi/acpi.h:457.  Symbols of type 'hex'
	  are always defined.

Since hex Kconfig are always defined there is no need to test it being
defined but also no need to handle zero or non-zero values.

In addition:

1. This config was defined in Meteor Lake specific Kconfig file while
   it should actually be define closer to where it is being used (here
   soc/intel/common/block/acpi/Kconfig) and only set by the SoC Kconfig.

2. Once moved and under control of `SOC_INTEL_COMMON_BLOCK_ACPI_LPIT'
   gating (lpit.c), the Kconfig name needed to be adjusted to better fit
   its use.

3. Make Meteor Lake Kconfig sets the config but does not define it
   anymore.

TEST=LPIT ACPI table Counter Frequency field is set to 0x2005 on rex

Change-Id: I2083c9209e61be6180cca2c9f74097e2f4b4ce9a
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78458
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Bora Guvendik <bora.guvendik@intel.com>
Reviewed-by: Sukumar Ghorai <sukumar.ghorai@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
2023-10-19 16:17:20 +00:00
..
acpi.h soc/intel: Improve CONFIG_ACPI_SOC_INTEL_SLP_S0_FREQ_HZ use 2023-10-19 16:17:20 +00:00
acpi_crat.h include/acpi/acpi_crat.h: Add missing <stdint.h> 2022-11-03 13:03:21 +00:00
acpi_device.h acpi: Helper functions to add certain _DSD properties 2022-12-05 14:30:57 +00:00
acpi_gnvs.h ACPI: Add usb_charge_mode_from_gnvs() 2023-08-16 17:55:02 +00:00
acpi_ivrs.h include/acpi: Use C99 flexible arrays 2023-08-01 12:55:42 +00:00
acpi_osc.h
acpi_pld.h include/acpi/acpi_pld.h: Remove comment on PLD 2023-09-28 21:26:39 +00:00
acpi_pm.h acpi/acpi_pm.c: refactor acpi_pm_state_for_* functions 2022-09-27 14:19:01 +00:00
acpi_sata.h
acpi_soundwire.h
acpigen.h acpi/acpigen: rename and clarify bus/IO/MMIO resource producer functions 2023-05-30 16:05:35 +00:00
acpigen_dptf.h Reland "drivers/intel/dptf: Add multiple fan support under dptf" 2023-04-12 14:11:45 +00:00
acpigen_dsm.h drivers/usb/acpi: Add USB _DSM method to enable/disable USB LPM per port 2023-01-19 05:58:33 +00:00
acpigen_pci.h
acpigen_ps2_keybd.h acpi/acpigen_ps2_keybd: Reduce minimum keys, optional alpha/num/punct 2023-10-02 16:24:54 +00:00
acpigen_usb.h ec/google/chromeec: Add retimer handle to Type C conn 2022-05-04 13:15:30 +00:00