73d042bd90
No board has ever tried to combine CONFIG_SEPARATE_VERSTAGE with CONFIG_VBOOT_STARTS_IN_ROMSTAGE. There are probably many reasons why this wouldn't work (e.g. x86 CAR migration logic currently always assumes verstage code to run pre-migration). It would also not really make sense: the reason we use separate verstages is to decrease bootblock size (mitigating the boot speed cost of slow boot ROM SPI drivers) and to allow the SRAM-saving RETURN_FROM_VERSTAGE trick, neither of which would apply to the after-romstage case. It is better to just forbid that case explicitly and give programmers more guarantees about what the verstage is (e.g. now the assumption that it runs pre-RAM is always valid). Since Kconfig dependencies aren't always guaranteed in the face of 'select' statements, also add some explicit compile-time assertions to the vboot code. We can simplify some of the loader logic which now no longer needs to provide for the forbidden case. In addition, also try to make some of the loader logic more readable by writing it in a more functional style that allows us to put more assertions about which cases should be unreachable in there, which will hopefully make it more robust and fail-fast with future changes (e.g. addition of new stages). Change-Id: Iaf60040af4eff711d9b80ee0e5950ce05958b3aa Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://review.coreboot.org/18983 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Tested-by: build bot (Jenkins)
183 lines
5.4 KiB
C
183 lines
5.4 KiB
C
/*
|
|
* This file is part of the coreboot project.
|
|
*
|
|
* Copyright 2014 Google Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; version 2 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
/* This file contains macro definitions for memlayout.ld linker scripts. */
|
|
|
|
#ifndef __MEMLAYOUT_H
|
|
#define __MEMLAYOUT_H
|
|
|
|
#include <rules.h>
|
|
#include <arch/memlayout.h>
|
|
|
|
/* Macros that the architecture can override. */
|
|
#ifndef ARCH_POINTER_ALIGN_SIZE
|
|
#define ARCH_POINTER_ALIGN_SIZE 8
|
|
#endif
|
|
|
|
#ifndef ARCH_CACHELINE_ALIGN_SIZE
|
|
#define ARCH_CACHELINE_ALIGN_SIZE 64
|
|
#endif
|
|
|
|
/* Default to data as well as bss. */
|
|
#ifndef ARCH_STAGE_HAS_DATA_SECTION
|
|
#define ARCH_STAGE_HAS_DATA_SECTION 1
|
|
#endif
|
|
|
|
#ifndef ARCH_STAGE_HAS_BSS_SECTION
|
|
#define ARCH_STAGE_HAS_BSS_SECTION 1
|
|
#endif
|
|
|
|
/* Default is that currently ramstage, smm, and rmodules have a heap. */
|
|
#ifndef ARCH_STAGE_HAS_HEAP_SECTION
|
|
#define ARCH_STAGE_HAS_HEAP_SECTION (ENV_RAMSTAGE || ENV_SMM || ENV_RMODULE)
|
|
#endif
|
|
|
|
#define STR(x) #x
|
|
|
|
#define ALIGN_COUNTER(align) \
|
|
. = ALIGN(align);
|
|
|
|
#define SET_COUNTER(name, addr) \
|
|
_ = ASSERT(. <= addr, STR(name overlaps the previous region!)); \
|
|
. = addr;
|
|
|
|
#define SYMBOL(name, addr) \
|
|
SET_COUNTER(name, addr) \
|
|
_##name = .;
|
|
|
|
#define REGION(name, addr, size, expected_align) \
|
|
SYMBOL(name, addr) \
|
|
_ = ASSERT(. == ALIGN(expected_align), \
|
|
STR(name must be aligned to expected_align!)); \
|
|
SYMBOL(e##name, addr + size)
|
|
|
|
#define ALIAS_REGION(name, alias) \
|
|
_##alias = _##name; \
|
|
_e##alias = _e##name;
|
|
|
|
/* Declare according to SRAM/DRAM ranges in SoC hardware-defined address map. */
|
|
#define SRAM_START(addr) SYMBOL(sram, addr)
|
|
|
|
#define SRAM_END(addr) SYMBOL(esram, addr)
|
|
|
|
#define DRAM_START(addr) SYMBOL(dram, addr)
|
|
|
|
#define TIMESTAMP(addr, size) \
|
|
REGION(timestamp, addr, size, 8) \
|
|
_ = ASSERT(size >= 212, "Timestamp region must fit timestamp_cache!");
|
|
|
|
#define PRERAM_CBMEM_CONSOLE(addr, size) \
|
|
REGION(preram_cbmem_console, addr, size, 4)
|
|
|
|
/* Use either CBFS_CACHE (unified) or both (PRERAM|POSTRAM)_CBFS_CACHE */
|
|
#define CBFS_CACHE(addr, size) \
|
|
REGION(cbfs_cache, addr, size, 4) \
|
|
ALIAS_REGION(cbfs_cache, preram_cbfs_cache) \
|
|
ALIAS_REGION(cbfs_cache, postram_cbfs_cache)
|
|
|
|
#if defined(__PRE_RAM__)
|
|
#define PRERAM_CBFS_CACHE(addr, size) \
|
|
REGION(preram_cbfs_cache, addr, size, 4) \
|
|
ALIAS_REGION(preram_cbfs_cache, cbfs_cache)
|
|
#define POSTRAM_CBFS_CACHE(addr, size) \
|
|
REGION(postram_cbfs_cache, addr, size, 4)
|
|
#else
|
|
#define PRERAM_CBFS_CACHE(addr, size) \
|
|
REGION(preram_cbfs_cache, addr, size, 4)
|
|
#define POSTRAM_CBFS_CACHE(addr, size) \
|
|
REGION(postram_cbfs_cache, addr, size, 4) \
|
|
ALIAS_REGION(postram_cbfs_cache, cbfs_cache)
|
|
#endif
|
|
|
|
/* Careful: 'INCLUDE <filename>' must always be at the end of the output line */
|
|
#if ENV_BOOTBLOCK
|
|
#define BOOTBLOCK(addr, sz) \
|
|
SYMBOL(bootblock, addr) \
|
|
_ebootblock = _bootblock + sz; \
|
|
_ = ASSERT(_eprogram - _program <= sz, \
|
|
STR(Bootblock exceeded its allotted size! (sz))); \
|
|
INCLUDE "bootblock/lib/program.ld"
|
|
#else
|
|
#define BOOTBLOCK(addr, sz) \
|
|
REGION(bootblock, addr, sz, 1)
|
|
#endif
|
|
|
|
#if ENV_ROMSTAGE
|
|
#define ROMSTAGE(addr, sz) \
|
|
SYMBOL(romstage, addr) \
|
|
_eromstage = _romstage + sz; \
|
|
_ = ASSERT(_eprogram - _program <= sz, \
|
|
STR(Romstage exceeded its allotted size! (sz))); \
|
|
INCLUDE "romstage/lib/program.ld"
|
|
#else
|
|
#define ROMSTAGE(addr, sz) \
|
|
REGION(romstage, addr, sz, 1)
|
|
#endif
|
|
|
|
#if ENV_RAMSTAGE
|
|
#define RAMSTAGE(addr, sz) \
|
|
SYMBOL(ramstage, addr) \
|
|
_eramstage = _ramstage + sz; \
|
|
_ = ASSERT(_eprogram - _program <= sz, \
|
|
STR(Ramstage exceeded its allotted size! (sz))); \
|
|
INCLUDE "ramstage/lib/program.ld"
|
|
#else
|
|
#define RAMSTAGE(addr, sz) \
|
|
REGION(ramstage, addr, sz, 1)
|
|
#endif
|
|
|
|
/* Careful: required work buffer size depends on RW properties such as key size
|
|
* and algorithm -- what works for you might stop working after an update. Do
|
|
* NOT lower the asserted minimum without consulting vboot devs (rspangler)! */
|
|
#define VBOOT2_WORK(addr, size) \
|
|
REGION(vboot2_work, addr, size, 16) \
|
|
_ = ASSERT(size >= 12K, "vboot2 work buffer must be at least 12K!");
|
|
|
|
#if ENV_VERSTAGE
|
|
#define VERSTAGE(addr, sz) \
|
|
SYMBOL(verstage, addr) \
|
|
_everstage = _verstage + sz; \
|
|
_ = ASSERT(_eprogram - _program <= sz, \
|
|
STR(Verstage exceeded its allotted size! (sz))); \
|
|
INCLUDE "verstage/lib/program.ld"
|
|
|
|
#define OVERLAP_VERSTAGE_ROMSTAGE(addr, size) \
|
|
_ = ASSERT(IS_ENABLED(CONFIG_RETURN_FROM_VERSTAGE) == 1, \
|
|
"Must set RETURN_FROM_VERSTAGE to overlap romstage."); \
|
|
VERSTAGE(addr, size)
|
|
#else
|
|
#define VERSTAGE(addr, sz) \
|
|
REGION(verstage, addr, sz, 1)
|
|
|
|
#define OVERLAP_VERSTAGE_ROMSTAGE(addr, size) ROMSTAGE(addr, size)
|
|
#endif
|
|
|
|
#if ENV_POSTCAR
|
|
#define POSTCAR(addr, sz) \
|
|
SYMBOL(postcar, addr) \
|
|
_epostcar = _postcar + sz; \
|
|
_ = ASSERT(_eprogram - _program <= sz, \
|
|
STR(Aftercar exceeded its allotted size! (sz))); \
|
|
INCLUDE "postcar/lib/program.ld"
|
|
#else
|
|
#define POSTCAR(addr, sz) \
|
|
REGION(postcar, addr, sz, 1)
|
|
#endif
|
|
|
|
#define WATCHDOG_TOMBSTONE(addr, size) \
|
|
REGION(watchdog_tombstone, addr, size, 4) \
|
|
_ = ASSERT(size == 4, "watchdog tombstones should be exactly 4 byte!");
|
|
|
|
#endif /* __MEMLAYOUT_H */
|