Perl 5.42.0 added a new warning for possible precedence problems between the `!` logical negation operator and various other operators [1]. In particular, the kconfig_lint script uses `!` and `=~` (binding operator) to check that a filename does not match a regex, but was written in a way that would be parsed as negating the filename and then comparing it to the regex. The resulting warning from the newer version of Perl caused lint-stable to fail on the lint-stable-008-kconfig test due to the non empty output, causing the pre-commit hook to fail. Fix this by using the negated binding operator `!~` instead as recommended by the Perl documentation [2]. [1] https://perldoc.perl.org/perl5420delta#New-Warnings [2] https://perldoc.perl.org/perldiag#Possible-precedence-problem-between-!-and-%25s Change-Id: I3631b8b0be92bf85a1510be1f1d4221a010be1ba Signed-off-by: Nicholas Chin <nic.c3.14@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/88619 Reviewed-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> |
||
|---|---|---|
| .. | ||
| check-style | ||
| check_lint_tests | ||
| checkpatch.pl | ||
| checkpatch_json.py | ||
| const_structs.checkpatch | ||
| coreboot.dict | ||
| description.md | ||
| helper_functions.sh | ||
| kconfig_lint | ||
| kconfig_lint_README | ||
| lint | ||
| lint-000-license-headers | ||
| lint-001-no-global-config-in-romstage | ||
| lint-007-checkpatch | ||
| lint-008-kconfig | ||
| lint-014-qualified-types | ||
| lint-extended-007-checkpatch | ||
| lint-extended-015-final-newlines | ||
| lint-extended-020-signed-off-by | ||
| lint-stable-000-license-headers | ||
| lint-stable-003-whitespace | ||
| lint-stable-004-style-labels | ||
| lint-stable-005-board-status | ||
| lint-stable-006-board-name | ||
| lint-stable-008-kconfig | ||
| lint-stable-009-old-licenses | ||
| lint-stable-010-asm-syntax | ||
| lint-stable-012-executable-bit | ||
| lint-stable-013-site-local | ||
| lint-stable-016-non-ascii | ||
| lint-stable-017-configs | ||
| lint-stable-018-symlinks | ||
| lint-stable-019-header-files | ||
| lint-stable-021-coreboot-lowercase | ||
| lint-stable-022-clang-format | ||
| lint-stable-023-filenames | ||
| lint-stable-024-kconfig-no-subsystem | ||
| lint-stable-026-line-endings | ||
| lint-stable-027-maintainers-syntax | ||
| lint-stable-028-touchpad-probed-warning | ||
| lint-stable-029-kconfig-name-selects | ||
| lint-stable-030-makefile-inc | ||
| lint-stable-031-gofmt | ||
| Makefile | ||
| remccoms3.sed | ||
| spelling.txt | ||