21a4053fde
When CONFIG_SEPARATE_VERSTAGE=n, all verstage code gets linked into the appropriate calling stage (bootblock or romstage). This means that ENV_VERSTAGE is actually 0, and instead ENV_BOOTBLOCK or ENV_ROMSTAGE are 1. This keeps tripping up people who are just trying to write a simple "are we in verstage (i.e. wherever the vboot init logic runs)" check, e.g. for TPM init functions which may run in "verstage" or ramstage depending on whether vboot is enabled. Those checks will not work as intended for CONFIG_SEPARATE_VERSTAGE=n. This patch renames ENV_VERSTAGE to ENV_SEPARATE_VERSTAGE to try to clarify that this macro can really only be used to check whether code is running in a *separate* verstage, and clue people in that they may need to cover the linked-in verstage case as well. Signed-off-by: Julius Werner <jwerner@chromium.org> Change-Id: I2ff3a3c3513b3db44b3cff3d93398330cd3632ea Reviewed-on: https://review.coreboot.org/c/coreboot/+/40582 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
90 lines
2.3 KiB
C
90 lines
2.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/* This file is part of the coreboot project. */
|
|
|
|
#ifndef __VBOOT_MISC_H__
|
|
#define __VBOOT_MISC_H__
|
|
|
|
#include <assert.h>
|
|
#include <security/vboot/vboot_common.h>
|
|
#include <vb2_api.h>
|
|
|
|
/*
|
|
* Source: security/vboot/common.c
|
|
*/
|
|
struct vb2_context *vboot_get_context(void);
|
|
|
|
/*
|
|
* Returns 1 if firmware slot A is used, 0 if slot B is used.
|
|
*/
|
|
static inline int vboot_is_firmware_slot_a(struct vb2_context *ctx)
|
|
{
|
|
return !(ctx->flags & VB2_CONTEXT_FW_SLOT_B);
|
|
}
|
|
|
|
/*
|
|
* Check if given flag is set in the flags field in GBB header.
|
|
* Return value:
|
|
* true: Flag is set.
|
|
* false: Flag is not set.
|
|
*/
|
|
static inline bool vboot_is_gbb_flag_set(enum vb2_gbb_flag flag)
|
|
{
|
|
return !!(vb2api_gbb_get_flags(vboot_get_context()) & flag);
|
|
}
|
|
|
|
/*
|
|
* Locates firmware as a region device. Returns 0 on success, -1 on failure.
|
|
*/
|
|
int vboot_locate_firmware(struct vb2_context *ctx, struct region_device *fw);
|
|
|
|
/*
|
|
* The stage loading code is compiled and entered from multiple stages. The
|
|
* helper functions below attempt to provide more clarity on when certain
|
|
* code should be called. They are implemented inline for better compile-time
|
|
* code elimination.
|
|
*/
|
|
|
|
static inline int verification_should_run(void)
|
|
{
|
|
if (CONFIG(VBOOT_SEPARATE_VERSTAGE))
|
|
return ENV_SEPARATE_VERSTAGE;
|
|
else if (CONFIG(VBOOT_STARTS_IN_ROMSTAGE))
|
|
return ENV_ROMSTAGE;
|
|
else if (CONFIG(VBOOT_STARTS_IN_BOOTBLOCK))
|
|
return ENV_BOOTBLOCK;
|
|
else
|
|
dead_code();
|
|
}
|
|
|
|
static inline int verstage_should_load(void)
|
|
{
|
|
if (CONFIG(VBOOT_SEPARATE_VERSTAGE))
|
|
return ENV_BOOTBLOCK;
|
|
else
|
|
return 0;
|
|
}
|
|
|
|
static inline int vboot_logic_executed(void)
|
|
{
|
|
extern int vboot_executed; /* should not be globally accessible */
|
|
|
|
/* If we are in the stage that runs verification, or in the stage that
|
|
both loads the verstage and is returned to from it afterwards, we
|
|
need to check a global to see if verification has run. */
|
|
if (verification_should_run() ||
|
|
(verstage_should_load() && CONFIG(VBOOT_RETURN_FROM_VERSTAGE)))
|
|
return vboot_executed;
|
|
|
|
if (CONFIG(VBOOT_STARTS_IN_BOOTBLOCK)) {
|
|
/* All other stages are "after the bootblock" */
|
|
return !ENV_BOOTBLOCK;
|
|
} else if (CONFIG(VBOOT_STARTS_IN_ROMSTAGE)) {
|
|
/* Post-RAM stages are "after the romstage" */
|
|
return !ENV_ROMSTAGE_OR_BEFORE;
|
|
} else {
|
|
dead_code();
|
|
}
|
|
}
|
|
|
|
|
|
#endif /* __VBOOT_MISC_H__ */
|