erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
coreboot/util/cbfstool
History
Gabe Black be48f3e41e cbfstool: Propogate compression errors back to the caller. 
When compression fails for whatever reason, the caller should know about it
rather than blindly assuming it worked correctly. That can prevent half
compressed data from ending up in the image.

This is currently happening for a segment of depthcharge which is triggering
a failure in LZMA. The size of the "compressed" data is never set and is
recorded as zero, and that segment effectively isn't loaded during boot.

BUG=chrome-os-partner:26060
TEST=Built with this change and saw that cbfstool no longer seems to succeed
or inserts a broken payload.
BRANCH=None

Change-Id: Idbff01f5413d030bbf5382712780bbd0b9e83bc7
Signed-off-by: Gabe Black <gabeblack@google.com>
Reviewed-on: https://chromium-review.googlesource.com/187364
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Tested-by: Gabe Black <gabeblack@chromium.org>
Commit-Queue: Gabe Black <gabeblack@chromium.org>
2014-02-24 13:35:19 +00:00
..
lzma cbfstool: Propogate compression errors back to the caller. 2014-02-24 13:35:19 +00:00
cbfs-mkpayload.c cbfstool: Propogate compression errors back to the caller. 2014-02-24 13:35:19 +00:00
cbfs-mkstage.c cbfstool: Propogate compression errors back to the caller. 2014-02-24 13:35:19 +00:00
cbfs.h Add section header parsing and use it in the mk-payload step 2014-01-24 23:51:48 +00:00
cbfs_image.c UPSTREAM: cbfstool: correct size left calculation for "empty" entries 2014-02-19 18:36:36 +00:00
cbfs_image.h cbfstool: add code to serialize the header using the new xdr functions 2014-01-25 05:54:30 +00:00
cbfstool.c Add section header parsing and use it in the mk-payload step 2014-01-24 23:51:48 +00:00
coff.h GPLv2 notice: Unify all files to just use one space in »MA 02110-1301« 2013-03-01 10:16:08 +01:00
common.c Add section header parsing and use it in the mk-payload step 2014-01-24 23:51:48 +00:00
common.h cbfstool: Propogate compression errors back to the caller. 2014-02-24 13:35:19 +00:00
compress.c cbfstool: Propogate compression errors back to the caller. 2014-02-24 13:35:19 +00:00
elf.h aarch64: Add ELF support 2014-02-21 19:31:15 +00:00
elfheaders.c aarch64: Add ELF support 2014-02-21 19:31:15 +00:00
EXAMPLE cbfstool: Update example file. 2013-02-04 11:12:15 +01:00
fit.c Add section header parsing and use it in the mk-payload step 2014-01-24 23:51:48 +00:00
fit.h cbfstool: Add update-fit command 2013-03-27 01:25:12 +01:00
fv.h GPLv2 notice: Unify all files to just use one space in »MA 02110-1301« 2013-03-01 10:16:08 +01:00
Makefile Add section header parsing and use it in the mk-payload step 2014-01-24 23:51:48 +00:00
Makefile.inc Add section header parsing and use it in the mk-payload step 2014-01-24 23:51:48 +00:00
swab.h Various fixes to cbfstool. 2011-10-24 20:29:29 +02:00
xdr.c cbfs: fix issues with word size and endianness. 2013-12-11 09:04:54 +00:00