39a1875f7d
Add three functions to edid.c: void set_vbe_mode_info_valid(struct edid *edid, uintptr_t fb_addr) takes an edid and uintptr_t, and fills in a static lb_framebuffer struct as well as setting the static vbe_valid to 1 unless some problem is found in the edid. The intent here is that this could be called from the native graphics setup code on both ARM and x86. int vbe_mode_info_valid(void) returns value of the static vbe_valid. void fill_lb_framebuffer(struct lb_framebuffer *framebuffer) copies the static edid_fb to lb_framebuffer. There is now a common vbe.h in src/include, removed the two special ones. In general, graphics in coreboot is a mess, but graphics is always a mess. We don't have a clean way to try two different ways to turn on a device and use the one that works. One battle at a time. Overall, things are much better. The best part: this code would also work for ARM, which also uses EDID. BUG=None TEST=build coreboot with and without native graphics enabled. It builds. Build with YABEL. It still builds. BRANCH=NONE Change-Id: Ieef2178e7e7fa850556c9af68e2d897a33aec871 Signed-off-by: Ronald G. Minnich <rminnich@google.com> Reviewed-on: https://gerrit.chromium.org/gerrit/48923 Reviewed-by: David Hendricks <dhendrix@chromium.org> Reviewed-by: Stefan Reinauer <reinauer@google.com> Commit-Queue: Ronald G. Minnich <rminnich@chromium.org> Tested-by: Ronald G. Minnich <rminnich@chromium.org> |
||
|---|---|---|
| .. | ||
| baskingridge | ||
| d810e2cb | ||
| d945gclf | ||
| eagleheights | ||
| emeraldlake2 | ||
| jarrell | ||
| mtarvon | ||
| truxton | ||
| wtm2 | ||
| xe7501devkit | ||
| Kconfig | ||