erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
coreboot/src/mainboard
History
Paul Menzel 2e585a12a2 sb/amd/cimx/sb800: Get rid of power button device in coreboot 
Apply commit d7b88dcb (mb/google/x86-boards: Get rid of power button
device in coreboot) to AMD Brazos boards [1]:

> As per the ACPI specification, there are two types of power button
> devices:
> 1. Fixed hardware power button
> 2. Generic hardware power button
>
> Fixed hardware power button is added by the OSPM if POWER_BUTTON flag
> is not set in FADT by the BIOS. This device has its programming model
> in PM1x_EVT_BLK. All ACPI compliant OSes are expected to add this
> power button device by default if the power button FADT flag is not
> set.
>
> On the other hand, generic hardware power button can be used by
> platforms if fixed register space cannot be used for the power button
> device. In order to support this, power button device object with HID
> PNP0C0C is expected to be added to ACPI tables. Additionally,
> POWER_BUTTON flag should be set to indicate the presence of control
> method for power button.
[..]
> This change gets rid of the generic hardware power button from all
> google mainboards and relies completely on the fixed hardware power
> button.

The same problem exists with the AMD Hudson devices in coreboot.

For AMD Hudson (2) and Yangtze based devices this was removed in commit
44f2fab8 (AMD hudson and yangtze boards: Let mainboard declare power
button) [2].

Two devices are detected.

    $ dmesg | grep Button
    [    0.209213] input: Power Button as /devices/LNXSYSTM:00/LNXSYBUS:00/PNP0C0C:00/input/input0
    [    0.209254] ACPI: Power Button [PWRB]
    [    0.209332] input: Power Button as /devices/LNXSYSTM:00/LNXPWRBN:00/input/input1
    [    0.209349] ACPI: Power Button [PWRF]

   $ sudo evtest
    No device specified, trying to scan all of /dev/input/event*
    Available devices:
    /dev/input/event0:      Power Button
    /dev/input/event1:      Power Button
    [..]

[1]: https://review.coreboot.org/5546
[2]: https://review.coreboot.org/27272

Change-Id: I0cbecb72f7e1bf3d051d3b7656c6af4d6f43b497
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/27496
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
2019-05-20 14:43:44 +00:00
..
adi src: Drop unused 'include <arch/acpigen.h>' 2019-03-12 07:27:28 +00:00
adlink
advansus src: Use 'include <string.h>' when appropriate 2019-03-20 20:27:51 +00:00
amd sb/amd/cimx/sb800: Get rid of power button device in coreboot 2019-05-20 14:43:44 +00:00
aopen src/mb/Kconfig: Fix PCI subsystem IDs 2019-04-19 17:48:15 +00:00
apple src/mainboard: Remove unneeded include <arch/io.h> 2019-05-15 17:59:05 +00:00
asrock sb/amd/cimx/sb800: Get rid of power button device in coreboot 2019-05-20 14:43:44 +00:00
asus src/mainboard: Remove unneeded include <arch/io.h> 2019-05-15 17:59:05 +00:00
avalue src: Use 'include <string.h>' when appropriate 2019-03-20 20:27:51 +00:00
bap src: Add missing include 'console.h' 2019-04-23 10:00:39 +00:00
biostar src: Add missing include 'console.h' 2019-04-23 10:00:39 +00:00
cavium src: Use 'include <string.h>' when appropriate 2019-03-20 20:27:51 +00:00
compulab nb/intel/snb: Drop NORTHBRIDGE_INTEL_IVYBRIDGE 2019-05-12 15:03:03 +00:00
cubietech src: Use include <console/console.h> when appropriate 2019-04-23 10:01:21 +00:00
elmex sb/amd/cimx/sb800: Get rid of power button device in coreboot 2019-05-20 14:43:44 +00:00
emulation src: Use 'include <string.h>' when appropriate 2019-03-20 20:27:51 +00:00
esd src: Use 'include <string.h>' when appropriate 2019-03-20 20:27:51 +00:00
facebook mb/facebook/watson: Don't use deprecated IS_ENABLED 2019-04-20 04:22:46 +00:00
foxconn src: Add missing include 'console.h' 2019-04-23 10:00:39 +00:00
getac src: Remove unused include <halt.h> 2019-05-06 10:39:01 +00:00
gigabyte mb/gigabyte/ga-b75m-d3{h,v}: Various cleanups 2019-05-16 20:19:24 +00:00
gizmosphere sb/amd/cimx/sb800: Get rid of power button device in coreboot 2019-05-20 14:43:44 +00:00
google mb/google/hatch: Change SD_CD# reset config to PLTRST 2019-05-20 14:42:27 +00:00
hp nb/intel/snb: Drop NORTHBRIDGE_INTEL_IVYBRIDGE 2019-05-12 15:03:03 +00:00
ibase src/mainboard: Remove unneeded include <arch/io.h> 2019-05-15 17:59:05 +00:00
iei src: Use 'include <string.h>' when appropriate 2019-03-20 20:27:51 +00:00
intel src/mainboard: Remove unneeded include <arch/io.h> 2019-05-15 17:59:05 +00:00
jetway sb/amd/cimx/sb800: Get rid of power button device in coreboot 2019-05-20 14:43:44 +00:00
kontron src/mainboard: Remove unneeded include <arch/io.h> 2019-05-15 17:59:05 +00:00
lenovo src/mainboard: Remove unneeded include <arch/io.h> 2019-05-15 17:59:05 +00:00
lippert src: Add missing include 'console.h' 2019-04-23 10:00:39 +00:00
msi mb/msi/ms7707: Remove MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} 2019-05-05 10:47:58 +00:00
ocp mb/ocp/monolake: replace IS_ENABLED(CONFIG_*) with CONFIG() 2019-05-16 20:16:38 +00:00
opencellular src: Use include <delay.h> when appropriate 2019-04-06 16:09:12 +00:00
packardbell mb/packardbell/ms2290/acpi: Serialize Control Method 2019-05-15 17:48:14 +00:00
pcengines sb/amd/cimx/sb800: Get rid of power button device in coreboot 2019-05-20 14:43:44 +00:00
purism soc/intel/broadwell: Clean up the bootflow 2019-05-14 23:22:51 +00:00
roda nb/intel/snb: Drop NORTHBRIDGE_INTEL_IVYBRIDGE 2019-05-12 15:03:03 +00:00
samsung mb/samsung/lumpy: Move onboard SPD to second channel 2019-05-13 09:28:11 +00:00
sapphire nb/intel/snb: Drop NORTHBRIDGE_INTEL_IVYBRIDGE 2019-05-12 15:03:03 +00:00
scaleway src: Use 'include <string.h>' when appropriate 2019-03-20 20:27:51 +00:00
siemens mb/siemens/mc_apl2: Limit SD-Card speed to DDR50 2019-05-06 04:35:08 +00:00
sifive src: Use include <console/console.h> when appropriate 2019-04-23 10:01:21 +00:00
supermicro mb/supermicro/x10slm-f: Do SIO setup in bootblock 2019-04-25 15:52:03 +00:00
ti device/mmio.h: Add include file for MMIO ops 2019-03-04 15:57:39 +00:00
tyan src: Use 'include <string.h>' when appropriate 2019-03-20 20:27:51 +00:00
via src: Use 'include <string.h>' when appropriate 2019-03-20 20:27:51 +00:00
Kconfig Kconfig: Unify power-after-failure options 2019-01-06 15:54:19 +00:00