coreboot/src/soc/intel/common
Nico Huber dca081b5e6 soc/intel/common/pmc: Avoid unnecessary writes of AFTERG3_EN
pmc_set_power_failure_state() is usually called twice, once upon boot
(with `target_on == true`) and once from SMM when the system is shut
down (with `target_on == false`). Assuming settings didn't change
between these calls, there is only one case where we actually need
to write the register value: when updating the state for the
MAINBOARD_POWER_STATE_PREVIOUS feature.

This suits us well as we want to avoid unnecessary writes so we
don't clobber the value set upon boot from within SMM. Due to
inaccessible option backends, SMM might not know the current
option state.

The assumption above, that the option value didn't change, may not
be true if the user changed the option on purpose. In the future,
one would have to reboot the machine for option changes to take
effect. However, this doesn't seem to make a huge difference: One
already needed a controlled shutdown for the update to take effect
before. A reboot doesn't seem much more expensive.

Change-Id: I58dd74b8b073f4f07db090bf7fddb14b5df8239a
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55539
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
2021-06-17 05:46:49 +00:00
..
acpi soc/intel: Rename and move MISCCFG_GPIO_PM_CONFIG_BITS definition to soc/gpio.h 2021-03-27 04:23:12 +00:00
basecode kconfig: remove non-existent source 2020-12-28 13:37:56 +00:00
block soc/intel/common/pmc: Avoid unnecessary writes of AFTERG3_EN 2021-06-17 05:46:49 +00:00
pch soc/intel/common/pch: Add server PCH option 2021-03-09 16:50:10 +00:00
fsp_reset.c soc/intel/common: Create common Intel FSP reset code block 2020-11-02 10:43:40 +00:00
hda_verb.c soc/intel/common/hda_verb.c: Fix up comment style 2021-03-22 12:59:57 +00:00
hda_verb.h
Kconfig.common ACPI: Drop redundant CBMEM_ID_ACPI_GNVS allocations 2021-01-10 11:15:10 +00:00
Makefile.inc soc/intel: Remove duplicate call to acpi_wake_source() 2021-01-29 19:35:25 +00:00
mma.c intel: mma: Use new CBFS API 2021-04-14 01:03:33 +00:00
mma.h intel: mma: Use new CBFS API 2021-04-14 01:03:33 +00:00
nhlt.c
reset.c Revert "soc/intel: Refactor do_global_reset() function" 2020-09-22 05:13:39 +00:00
reset.h Revert "soc/intel: Refactor do_global_reset() function" 2020-09-22 05:13:39 +00:00
smbios.c device/dram/ddr3: Rename DDR3 SPD memory types 2021-04-05 13:01:37 +00:00
smbios.h
tpm_tis.c
vbt.c
vbt.h