erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
coreboot/src/include
History
Julius Werner c445b4fc77 chromeos: Simplify fill_lb_gpios even further 
A long time ago many Chrome OS boards had pages full of duplicated
boilerplate code for the fill_lb_gpios() function, and we spent a lot of
time bikeshedding a proper solution that passes a table of lb_gpio
structs which can be concisely written with a static struct initializer
in http://crosreview.com/234648. Unfortunately we never really finished
that patch and in the mean time a different solution using the
fill_lb_gpio() helper got standardized onto most boards.

Still, that solution is not quite as clean and concise as the one we had
already designed, and it also wasn't applied consistently to all recent
boards (causing more boards with bad code to get added afterwards). This
patch switches all boards newer than Link to the better solution and
also adds some nicer debug output for the GPIOs while I'm there.

If more boards need to be converted from fill_lb_gpio() to this model
later (e.g. from a branch), it's quite easy to do with:
s/fill_lb_gpio(gpio++,\n\?\s*\([^,]*\),\n\?\s*\([^,]*\),\n\?\s*\([^,]*\),\n\?\s*\([^,]*\));/\t{\1, \2, \4, \3},/

Based on a patch by Furquan Shaikh <furquan@google.com>.

BUG=None
BRANCH=None
TEST=Booted on Oak. Ran abuild -x.

Change-Id: I449974d1c75c8ed187f5e10935495b2f03725811
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/14226
Tested-by: build bot (Jenkins)
Reviewed-by: David Hendricks <dhendrix@chromium.org>
2016-04-05 00:50:56 +02:00
..
boot chromeos: Simplify fill_lb_gpios even further 2016-04-05 00:50:56 +02:00
console arch/x86: introduce postcar stage/phase 2016-03-23 14:24:30 +01:00
cpu mtrr: Define a function for obtaining free var mtrr 2016-03-18 19:14:52 +01:00
device device: Add i2c read/write register field API 2016-03-21 23:10:55 +01:00
pc80 drivers/pc80: Add PS/2 mouse presence detect 2016-02-01 22:10:46 +01:00
smp atomic.h: Fix doxygen errors 2015-01-04 20:03:28 +01:00
superio tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
sys commonlib: Prepare code to be included in cbfstool builds. 2016-01-06 01:11:32 +01:00
tpm_lite vboot2: read secdata and nvdata 2015-03-23 19:51:47 +01:00
antirollback.h chromeos: vboot2: Add TPM PCR extension support 2015-04-20 17:06:28 +02:00
assert.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
b64_decode.h lib: add base64 decoder 2015-04-22 08:50:54 +02:00
base3.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
bcd.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
boardid.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
boot_device.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
bootblock_common.h lib/bootblock: provide SoC callback parity with mainboard 2016-02-26 02:16:14 +01:00
bootmem.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
bootmode.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
bootstate.h lib: Add Kconfig to toggle boot state debugging 2016-02-18 00:01:14 +01:00
cbfs.h cbfs: Add LZ4 in-place decompression support for pre-RAM stages 2016-02-22 21:38:37 +01:00
cbmem.h cbmem: Add comment for cbmem_top returning NULL if backing store is not ready 2016-03-29 19:40:23 +02:00
delay.h timer: Reestablish init_timer(), consolidate timer initialization calls 2015-04-14 09:03:28 +02:00
edid.h edid: Add helper function to calculate bits-per-pixel dependent values 2016-03-24 20:25:12 +01:00
elog.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
endian.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
fallback.h cbfs: new API and better program loading 2015-06-02 14:09:31 +02:00
fmap.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
gic.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
gpio.h gpio: Add support for binary_first base3 number system 2016-03-22 21:18:30 +01:00
halt.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
imd.h cbmem: add coreboot table records for each cbmem entry 2015-11-03 00:19:46 +01:00
inttypes.h x86: provide more C standard environment 2013-03-20 04:20:25 +01:00
ip_checksum.h Drop prototype guarding for romcc 2013-05-10 00:06:46 +02:00
kconfig.h Add config_enabled() from Linux 2012-05-08 00:36:09 +02:00
lib.h lzma: Port size-checking ulzman() version to coreboot 2016-02-12 22:00:55 +01:00
main_decl.h arches: lib: add main_decl.h for main() declaration 2016-02-11 23:29:08 +01:00
memlayout.h arch/x86: introduce postcar stage/phase 2016-03-23 14:24:30 +01:00
memory_info.h smbios: add funtion for smbios type17 2015-03-27 09:55:21 +01:00
memrange.h lib/memrange: add function to initialize range_entry 2016-03-09 16:46:16 +01:00
nhlt.h nhlt: add api to override oem_id and oem_table_id of acpi_header_t 2016-02-09 13:21:39 +01:00
option.h option: Add arch-agnostic get_option() 2014-03-04 15:23:10 +01:00
program_loading.h lib/prog_loading: introduce prog_segment_loaded() 2016-04-02 03:56:37 +02:00
reg_script.h fsp_baytrail: Add full support for iosf access in reg_script 2016-02-22 19:25:28 +01:00
reset.h vboot2: implement select_firmware for pre-romstage verification 2015-01-27 01:43:01 +01:00
rmodule.h lib/rmodule: export parameters in struct rmod_stage_load 2016-03-22 13:54:52 +01:00
romstage_handoff.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
rtc.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
rules.h arch/x86: introduce postcar stage/phase 2016-03-23 14:24:30 +01:00
sdram_mode.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
smbios.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
spd.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
spd_cache.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
spd_ddr2.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
spi-generic.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
spi_flash.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
stage_cache.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
stddef.h Provide a gcc-safe zero pointer 2016-01-28 23:25:53 +01:00
stdlib.h coreboot: introduce commonlib 2015-09-22 21:21:34 +00:00
string.h lib: Fix strncmp 2015-12-16 01:14:22 +01:00
swab.h include: Fix spelling 2013-07-11 22:36:19 +02:00
symbols.h memlayout: Add symbols for stage bounds 2016-02-22 21:38:07 +01:00
thread.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
timer.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
timestamp.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
tpm.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
trace.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
types.h tree: drop last paragraph of GPL copyright header 2015-10-31 21:37:39 +01:00
vbe.h intel/gma: Clarify code and use dedicated init for Google Peppy 2014-08-25 22:36:03 +02:00
version.h build.h: remove variable for the builduser, -hostname and -domain 2015-03-09 17:53:16 +01:00
watchdog.h watchdog.h: Fix compile time error on disabling watchdog handling 2013-03-12 12:06:43 +01:00
wrdd.h lib: Implement framework for retrieving WiFi regulatory domain 2016-01-22 16:12:17 +01:00