coreboot/src
Marc Jones 24462e6507 x86/acpigen: Fix ACPI _ROM method
Fix the following Error:
FAILED [LOW] AMLAsmASL_MSG_SERIALIZED_REQUIRED: Test 1, Assembler remark in line
142
Line | AML source
--------------------------------------------------------------------------------
00139|
00140|     Scope (\_SB.PCI0.IGFX)
00141|     {
00142|         Method (_ROM, 2, NotSerialized)  // _ROM: Read-Only Memory
     |                   ^
     | Remark 2120: Control Method should be made Serialized    (due to creation of named objects within)
00143|         {
00144|             OperationRegion (ROMS, SystemMemory, 0xCD520000, 0xFE00)
00145|             Field (ROMS, AnyAcc, NoLock, Preserve)
================================================================================

ADVICE: (for Remark #2120, ASL_MSG_SERIALIZED_REQUIRED): A named object is
created inside a non-serialized method - this method should be serialized. It is
possible that one thread enters the method and blocks and then a second thread
also executes the method, ending up in two attempts to create the object and
causing a failure.

Use the acpigen_write_method_serialized() to correct the error.

BUG=b:112476331
TEST=Run FWTS.

Change-Id: I145c3c3103efb4a02b4e02dd177f4bf50a2c7b3e
Signed-off-by: Marc Jones <marcj303@gmail.com>
Reviewed-on: https://review.coreboot.org/28124
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
2018-08-17 21:10:04 +00:00
..
acpi arch/x86: Add common AMD ACPI hardware definitions 2017-11-10 19:15:38 +00:00
arch x86/acpigen: Fix ACPI _ROM method 2018-08-17 21:10:04 +00:00
commonlib src/{commonlib,lib}: Fix typo 2018-08-16 18:55:08 +00:00
console arch/x86: Drop leftover ROMCC console support 2018-06-08 03:31:12 +00:00
cpu intel/socket_mPGA604: Keep only model f2x 2018-08-17 12:26:36 +00:00
device src/device: Fix typo 2018-08-09 15:57:35 +00:00
drivers src: Remove duplicated 'include <device/device.h>' 2018-08-14 23:25:59 +00:00
ec ec/google/chromeec: Fix ACPI FWTS error 2018-08-17 21:09:45 +00:00
include src/include: add more msr defines 2018-08-17 20:13:21 +00:00
lib src/{commonlib,lib}: Fix typo 2018-08-16 18:55:08 +00:00
mainboard mainboard/google/kahlee: Fix ACPI method Not Serialized error 2018-08-17 21:09:30 +00:00
northbridge Fix PCI ACPI _OSC methods 2018-08-17 21:09:17 +00:00
security cr50: Allow boards to disable powering off EC on cr50 update 2018-08-17 12:27:23 +00:00
soc Fix PCI ACPI _OSC methods 2018-08-17 21:09:17 +00:00
southbridge Fix PCI ACPI _OSC methods 2018-08-17 21:09:17 +00:00
superio superio/ite/it8720f: fix power control init 2018-08-17 18:27:00 +00:00
vendorcode cr50: Allow boards to disable powering off EC on cr50 update 2018-08-17 12:27:23 +00:00
Kconfig Kconfig: Make the EM100 config option common 2018-07-16 07:41:14 +00:00