erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
coreboot/src/mainboard
History
Julius Werner f67f2b0d4c google/trogdor: Always initialize eDP bridge I2C QUP firmware 
In CB:52662 when MIPI display support was added, we accidentally changed
the code flow for eDP displays such that i2c_init() will no longer be
called when display_init_required() is false. This is a problem because
on this platform, i2c_init() does not just prepare the I2C controller
for firmware use, it also loads firmware to the controller that makes it
behave like an I2C device in the first place -- a step that the kernel
cannot later do on its own if the firmware didn't already do it.
Skipping this initialization means the I2C controller becomes unusable
to the kernel.

This patch fixes the issue by making the i2c_init() unconditional again.

Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: Ie4546c31d87d91113eeef7dc7a18599a87e6d6eb
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58026
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
2021-09-29 21:07:30 +00:00
..
51nb mb/51nb/x210: Clean up dsdt.asl 2021-09-27 13:25:32 +00:00
acer mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
adlink
amd soc/amd: rename program_gpios to gpio_configure_pads 2021-09-23 14:42:03 +00:00
aopen mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
apple mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
asrock skylake DDR4 boards: Set CaVrefConfig to 2 2021-09-17 01:05:20 +00:00
asus mb/**/gma-mainboard.ads: Use lowercase for others 2021-09-06 13:39:01 +00:00
bap src/*: Specify type of DIMM_SPD_SIZE once 2021-09-03 00:10:33 +00:00
biostar mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
bostentech mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
cavium mb/*: Specify type of FMDFILE once 2021-07-26 14:06:57 +00:00
clevo skylake DDR4 boards: Set CaVrefConfig to 2 2021-09-17 01:05:20 +00:00
compulab mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
dell mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
elmex mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
emulation mb/*: Specify type of FMDFILE once 2021-07-26 14:06:57 +00:00
example x86: Add a minimal example SoC along with a board 2020-10-30 21:34:18 +00:00
facebook mb/facebook/monolith: Clean up dsdt.asl 2021-09-27 13:24:31 +00:00
foxconn mb/*: Specify type of OVERRIDE_DEVICETREE once 2021-07-26 14:06:36 +00:00
getac ec/acpi: Remove empty "chip" driver 2021-09-08 18:48:53 +00:00
gigabyte mb/*: Specify type of VARIANT_DIR once 2021-07-26 14:07:38 +00:00
gizmosphere src/*: Specify type of DIMM_SPD_SIZE once 2021-09-03 00:10:33 +00:00
google google/trogdor: Always initialize eDP bridge I2C QUP firmware 2021-09-29 21:07:30 +00:00
hp skylake: Default to BOARD_TYPE_DESKTOP for PCH-H 2021-09-03 00:12:37 +00:00
ibase mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
intel mb/intel/adlrvp, mb/google/brya: Add ADLP 242 PLx configurations 2021-09-29 10:07:06 +00:00
jetway mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
kontron skylake DDR4 boards: Set CaVrefConfig to 2 2021-09-17 01:05:20 +00:00
lenovo mb/lenovo/x60: Fix devicetree hierarchy 2021-09-08 18:52:15 +00:00
libretrend src/*: Specify type of DIMM_MAX once 2021-09-03 00:11:02 +00:00
lippert soc/amd/common/include/acpimmio: reduce visibility of GPIO MMIO access 2021-09-08 00:16:37 +00:00
msi AGESA f15tn: Factor out common OptionsIds.h 2021-08-22 22:15:09 +00:00
ocp soc/intel/xeon_sp/cpx: Use FSP repo 2021-09-23 06:38:52 +00:00
opencellular mb/*: Specify type of FMDFILE once 2021-07-26 14:06:57 +00:00
packardbell mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
pcengines soc/amd/common/blocks/include: rename gpio_banks.h to gpio.h 2021-09-23 18:33:00 +00:00
pine64 mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
portwell mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
prodrive mb/prodrive/hermes: Hook up P2SB and PMC in devicetree 2021-09-13 09:49:51 +00:00
protectli src/*: Specify type of DIMM_MAX once 2021-09-03 00:11:02 +00:00
purism mb/purism/librem_skl: Clean up dsdt.asl 2021-09-28 20:44:33 +00:00
razer mb/razor/blade_stealth_kbl: Clean up dsdt.asl 2021-09-27 13:25:04 +00:00
roda ec/acpi: Remove empty "chip" driver 2021-09-08 18:48:53 +00:00
samsung mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
sapphire mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
scaleway mb/scaleway/tagada/bmcinfo: replace stdbool.h include with types.h 2021-09-17 20:27:58 +00:00
siemens src/*: Specify type of DIMM_SPD_SIZE once 2021-09-03 00:10:33 +00:00
sifive mb/*: Specify type of MAINBOARD_PART_NUMBER once 2021-07-26 14:05:29 +00:00
supermicro skylake DDR4 boards: Set CaVrefConfig to 2 2021-09-17 01:05:20 +00:00
system76 mb/system76/gaze15: Disable OC support 2021-09-27 13:27:51 +00:00
ti mb/*: Specify type of FMDFILE once 2021-07-26 14:06:57 +00:00
up mb/up/squared: Undo set primary GPU via FSP option 2021-09-14 10:35:21 +00:00
Kconfig mb/*: Specify type of VARIANT_DIR once 2021-07-26 14:07:38 +00:00