coreboot/src/mainboard
Tim Van Patten 00864fdba6 mb/google/guybrush: Disable WLAN ASPM
ASPM on the WLAN PCIe bus introduces large latency spikes, which can be
measured with cyclictest:

$ cyclictest --policy=rr --priority=12 --interval=10000 --threads=1 --loops=6000

Disabling ASPM for WLAN reduces the latency spikes from 2,500-3,000 usec
down to 35-65 usec. These latency spikes can impact the user when
real-time processes like Audio (cras) are starved of CPU time, leading
to buffer underruns resulting in crackling/distorted audio.

ASPM is already disabled for Nipperkin devices (CB:63537), so this CL
disables it for both in the shared declaration of
guybrush_czn_dxio_descriptors.

Power impact for Dewatt:

* ASPM enabled

    power_VideoCall.FDO_25min_webrtc
    w_energy_rate 7.425043688811071

    power_Idle.default20min
    wh_energy_used 1.4164200000000022

* ASPM disabled

    power_VideoCall.FDO_25min_webrtc
    w_energy_rate 8.779998551703423

    power_Idle.default20min
    wh_energy_used 1.4860800000000012

When using Google Meet over WiFi, power increases by ~1.5W.

BUG=b:297970318
TEST=cyclictest --policy=rr --priority=12 --interval=10000 --threads=1 --loops=6000

Change-Id: I16940987d598943bd5d6ace8b4008eba4d4a177c
Signed-off-by: Tim Van Patten <timvp@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77963
Reviewed-by: Martin L Roth <gaumless@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
2023-09-29 17:47:39 +00:00
..
51nb
acer
adlink
amd soc/amd/genoa/reset.c: Add reset methods 2023-09-28 16:32:13 +00:00
aopen
apple mainboard: Add SPDX license headers to Makefiles 2023-08-06 19:28:50 +00:00
asrock mb/asrock/b75m-itx: Order Kconfig selects alphabetically 2023-09-29 02:35:10 +00:00
asus mainboard: Add SPDX license headers to Makefiles 2023-08-06 19:28:50 +00:00
biostar mainboard: Add SPDX license headers to Makefiles 2023-08-06 19:28:50 +00:00
bostentech
bytedance mainboard: Add SPDX license headers to Makefiles 2023-08-06 19:28:50 +00:00
cavium
clevo mb/clevo/cml-u: Move selects from Kconfig.name to Kconfig 2023-09-25 22:35:14 +00:00
compulab mainboard: Add SPDX license headers to Makefiles 2023-08-06 19:28:50 +00:00
dell
emulation mainboard: Add SPDX license headers to Makefiles 2023-08-06 19:28:50 +00:00
example
facebook treewide: convert to tpm_result_t 2023-09-28 16:54:37 +00:00
foxconn mainboard: Add SPDX license headers to Makefiles 2023-08-06 19:28:50 +00:00
getac
gigabyte mainboard: Add SPDX license headers to Makefiles 2023-08-06 19:28:50 +00:00
google mb/google/guybrush: Disable WLAN ASPM 2023-09-29 17:47:39 +00:00
hp mb/hp/compaq_elite_8300_usdt: enable mSATA 2023-08-24 22:07:14 +00:00
ibase mainboard: Add SPDX license headers to Makefiles 2023-08-06 19:28:50 +00:00
ibm mb/ibm/sbp1: call soc soc_config_iio to configure IIO UPD 2023-08-09 13:48:04 +00:00
intel soc/intel/alderlake: Move C State Demotion to mainboard config 2023-09-26 16:19:56 +00:00
inventec mainboard: Add SPDX license headers to Makefiles 2023-08-06 19:28:50 +00:00
kontron mainboard: Add SPDX license headers to Makefiles 2023-08-06 19:28:50 +00:00
lenovo mb/lenovo: Remove space between function name and '(' 2023-09-11 21:38:13 +00:00
libretrend
msi mb/msi/ms7d25: Configure ASPM and Clock PM based on Kconfig 2023-09-01 13:20:34 +00:00
ocp
opencellular
packardbell mb/packardbell: Remove space between function name and '(' 2023-09-11 21:39:45 +00:00
pcengines
pine64
portwell
prodrive
protectli mainboard/protectli/vault_cml: Switch to IT8784E 2023-08-07 21:29:02 +00:00
purism mb/purism/librem_l1um_v2: Add support for Purism Librem L1UM v2 2023-09-25 14:10:51 +00:00
razer
roda
samsung ACPI: Add usb_charge_mode_from_gnvs() 2023-08-16 17:55:02 +00:00
sapphire
siemens mb/siemens/mc_ehl3: Enable PWM passthrough mode on PTN3460 2023-09-14 16:03:03 +00:00
sifive mb/emulation/*: Use newer function for resource declarations 2023-07-12 09:33:53 +00:00
starlabs mb/starlabs/starbook/rpl: Enable the PD interrupt GPIO 2023-09-08 12:45:35 +00:00
supermicro supermicro/x11-lga1151-series: Move selects from Kconfig.name to Kconfig 2023-09-25 22:34:29 +00:00
system76 soc/intel/alderlake: Move C State Demotion to mainboard config 2023-09-26 16:19:56 +00:00
ti
up mainboard: Add SPDX license headers to Makefiles 2023-08-06 19:28:50 +00:00
Kconfig