It's an option only available in coreboot's checkpatch fork at this
time. Reenable when upstream (ie. Linux) supports it and that version
was downstreamed into cros_sdk.
TEST=cros hooks don't fail on coreboot
Change-Id: I6e718ea13fda19df13a62295359f1607d122ef58
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/453778
Reviewed-by: Julius Werner <jwerner@chromium.org>
- Remove the "MISSING_SPACE" check which checks for breaks at a space in
a string concatenation. Most of the time this makes sense, but we
occasionally need to break where there isn't a space, so having a hard
rule doesn't always work.
- Don't check the vendorcode directory for compliance to coreboot's
code format rules.
BUG=none
BRANCH=none
TEST=none
Change-Id: If6648109dac8e91066f03e8d3c733db2f239b978
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 2e17eaed1b
Original-Change-Id: Ic07677b19520b5d22363834c77f5dee7bba9e429
Original-Signed-off-by: Martin Roth <martinroth@google.com>
Original-Reviewed-on: https://review.coreboot.org/18569
Original-Tested-by: build bot (Jenkins)
Original-Reviewed-by: Lee Leahy <leroy.p.leahy@intel.com>
Original-Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Original-Reviewed-by: Philippe Mathieu-Daud <philippe.mathieu.daude@gmail.com>
Reviewed-on: https://chromium-review.googlesource.com/452365
- Don't require a description of every config statement in the
Kconfig changes
- Don't complain about externs in .c files
- Don't complain about the use of the volatile keyword. The kernel
may not want it, but we definitely need it.
- Disable checks that seem to be broken.
BUG=None
BRANCH=None
TEST=None
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/16010
Tested-by: build bot (Jenkins)
Reviewed-by: Alexander Couzens <lynxis@fe80.eu>
Change-Id: Ic419b81cd36852a91e887e610d4a04984ab5fbd7
Reviewed-on: https://chromium-review.googlesource.com/381010
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Linux' newest checkpatch.pl flags comments like these:
/* This is a concise 2-line comment that explains what the code does in
* sufficient detail without wasting too much vertical space. */
do_stuff_that_needs_explaining();
Comments like these have been used in our code base for a long time and
I don't think we should disallow them now. Ending the comment on the
same line doesn't really hurt readability and wastes less screen real
estate (which in turn usually helps overall code comprehension).
BUG=None
BRANCH=None
TEST=None
Change-Id: I4d0d7c166c3ecd81a8a0d8a4c5133414c9cb5841
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/16060
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/368401
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
The newest checkpatch version now flags code such as
int i;
for (i = 0; ...
because there is no blank line between a declaration and the next
statement. We have always allowed variable declarations inline with the
code in coreboot and libpayload, so this doesn't make much sense for
us. Add it to the ignore list.
BRANCH=None
BUG=None
TEST=None
Change-Id: I865d69ccdd30e89083cfee5ca9c2332bfc6c1970
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/341513
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/346297
Reviewed-by: Aaron Durbin <adurbin@google.com>
Commit-Queue: Martin Roth <martinroth@chromium.org>
Trybot-Ready: Martin Roth <martinroth@chromium.org>
Tested-by: Martin Roth <martinroth@chromium.org>
- Remove submodules, since CrOS glues repos together using portage
- Add COMMIT-QUEUE.ini, PRESUBMIT.cfg, .checkpatch.conf from 2016.02
Change-Id: I06b428191699034bf20b086ce88b7b27c3deb41b
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/327003
Reviewed-by: Stefan Reinauer <reinauer@google.com>
