From ffda4b3d225354dccb153dba1563801547fcd512 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Mon, 1 Aug 2016 15:56:09 +0200 Subject: [PATCH] UPSTREAM: i2c/w83795: Fix chip type message (val & 4) == 1 is always false. Since val & 4 is either zero or non-zero, just drop the second test (for "== 1"). Validated against the data sheet that this is really the right register, bit and value. BUG=None BRANCH=None TEST=None Change-Id: Ie2a8aa09bd9c7c43608bda49c9101a87b9bdcdad Signed-off-by: Patrick Georgi Found-by: Coverity Scan #1241864 Reviewed-on: https://review.coreboot.org/16009 Tested-by: build bot (Jenkins) Reviewed-by: Kysti Mlkki Reviewed-by: Paul Menzel Reviewed-on: https://chromium-review.googlesource.com/367361 Commit-Ready: Furquan Shaikh Tested-by: Furquan Shaikh Reviewed-by: Furquan Shaikh --- src/drivers/i2c/w83795/w83795.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drivers/i2c/w83795/w83795.c b/src/drivers/i2c/w83795/w83795.c index 24da12c06a..02b7c375a6 100644 --- a/src/drivers/i2c/w83795/w83795.c +++ b/src/drivers/i2c/w83795/w83795.c @@ -160,7 +160,7 @@ static void w83795_init(struct device *dev, w83795_fan_mode_t mode, u8 dts_src) val = w83795_read(dev, W83795_REG_CONFIG); if ((val & W83795_REG_CONFIG_CONFIG48) == 0) printk(BIOS_INFO, "Found 64 pin W83795G Nuvoton H/W Monitor\n"); - else if ((val & W83795_REG_CONFIG_CONFIG48) == 1) + else printk(BIOS_INFO, "Found 48 pin W83795ADG Nuvoton H/W Monitor\n"); /* Reset */