erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UPSTREAM: skylake: fix VSDIO is at 0.8V when SDCard is not inserted

Browse source 
1. Enable SoC SD_CMD/D* signals pull-down of 20k when SD-card
   is removed. When SD-card is disconnected, the pull-down is
   disabled.
2. Provide path for weak leakage from buffers of SD_CMD/D* signal
   to be grounded. Thus dropping voltage on the SD_CMD/D* signals to ~0V.

BUG=chrome-os-partner:54421
BRANCH=None
TEST=no power leakage when SDCard isn't inserted on skylake platform

Change-Id: Iec4625f4cc98c1cb92f812dc74072ed3780aee79
Signed-off-by: Zhuo-hao.Lee <zhuo-hao.lee@intel.com>
Reviewed-on: https://review.coreboot.org/15910
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/365324
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Zhuo-hao.Lee 2016-07-27 13:18:22 +08:00 • committed by chrome-bot
commit fe972a6835
1 changed files with 16 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/soc/intel/skylake/acpi/scs.asl
View file

@ -88,6 +88,14 @@ Device (SDXC)
Method (_PS0, 0, Serialized)
{
/* Disable 20K pull-down on CLK, CMD and DAT lines */
^^PCRA (PID_GPIOCOM3, 0x4c4, 0xFFFFEFFF)
^^PCRA (PID_GPIOCOM3, 0x4cc, 0xFFFFEFFF)
^^PCRA (PID_GPIOCOM3, 0x4d4, 0xFFFFEFFF)
^^PCRA (PID_GPIOCOM3, 0x4dc, 0xFFFFEFFF)
^^PCRA (PID_GPIOCOM3, 0x4e4, 0xFFFFEFFF)
^^PCRA (PID_GPIOCOM3, 0x4f4, 0xFFFFEFFF)
/* Disable Power Gate */
Store (0, ^PGEN)
@ -113,6 +121,14 @@ Device (SDXC)
Store (3, Local0)
Store (Local0, ^D0D3)
Store (^D0D3, Local0)
/* Enable 20K pull-down on CLK, CMD and DAT lines */
^^PCRO (PID_GPIOCOM3, 0x4c4, 0x00001000)
^^PCRO (PID_GPIOCOM3, 0x4cc, 0x00001000)
^^PCRO (PID_GPIOCOM3, 0x4d4, 0x00001000)
^^PCRO (PID_GPIOCOM3, 0x4dc, 0x00001000)
^^PCRO (PID_GPIOCOM3, 0x4e4, 0x00001000)
^^PCRO (PID_GPIOCOM3, 0x4f4, 0x00001000)
}
Device (CARD)