From fd5f06244692fd536468a4e2d17817a1339ede13 Mon Sep 17 00:00:00 2001 From: Keith Hui Date: Mon, 16 Feb 2026 21:08:59 -0500 Subject: [PATCH] mb/asus/p8x7x-series/*tree.cb: Consolidate gen1_dec into baseboard It sets the PCH generic I/O decode range #1, meant for hardware monitor functionalities, which are same across all variants with no reason to deviate from. Move it into baseboard devicetree.cb. TEST=Timeless binaries remain identical for all variants. Change-Id: I7eecb81c02ed8c4b9bceb4cf9aff92a2bbe54ad7 Signed-off-by: Keith Hui Reviewed-on: https://review.coreboot.org/c/coreboot/+/91306 Reviewed-by: Patrick Rudolph Tested-by: build bot (Jenkins) --- src/mainboard/asus/p8x7x-series/devicetree.cb | 1 + src/mainboard/asus/p8x7x-series/variants/p8c_ws/overridetree.cb | 1 - .../asus/p8x7x-series/variants/p8h77-v/overridetree.cb | 1 - .../asus/p8x7x-series/variants/p8z77-m/overridetree.cb | 1 - .../asus/p8x7x-series/variants/p8z77-m_pro/overridetree.cb | 1 - .../asus/p8x7x-series/variants/p8z77-v/overridetree.cb | 1 - .../asus/p8x7x-series/variants/p8z77-v_le_plus/overridetree.cb | 1 - .../asus/p8x7x-series/variants/p8z77-v_lx2/overridetree.cb | 2 -- 8 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/mainboard/asus/p8x7x-series/devicetree.cb b/src/mainboard/asus/p8x7x-series/devicetree.cb index eb7a243ba0..edf1e6dc77 100644 --- a/src/mainboard/asus/p8x7x-series/devicetree.cb +++ b/src/mainboard/asus/p8x7x-series/devicetree.cb @@ -21,6 +21,7 @@ chip northbridge/intel/sandybridge register "spi_uvscc" = "0x2005" register "superspeed_capable_ports" = "0x0000000f" register "xhci_switchable_ports" = "0x0000000f" + register "gen1_dec" = "0x000c0291" # Hardware Monitor device ref xhci on end device ref ehci2 on end diff --git a/src/mainboard/asus/p8x7x-series/variants/p8c_ws/overridetree.cb b/src/mainboard/asus/p8x7x-series/variants/p8c_ws/overridetree.cb index c0d38b6dc9..a8e6029998 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8c_ws/overridetree.cb +++ b/src/mainboard/asus/p8x7x-series/variants/p8c_ws/overridetree.cb @@ -6,7 +6,6 @@ chip northbridge/intel/sandybridge device ref peg60 on end # PCIEX16_3 (electrical x4) subsystemid 0x1043 0x84ca inherit chip southbridge/intel/bd82x6x - register "gen1_dec" = "0x000c0291" register "usb_port_config" = "{ { 1, 0, 0 }, { 1, 0, 0 }, diff --git a/src/mainboard/asus/p8x7x-series/variants/p8h77-v/overridetree.cb b/src/mainboard/asus/p8x7x-series/variants/p8h77-v/overridetree.cb index f1decba0ca..ba18f3cd45 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8h77-v/overridetree.cb +++ b/src/mainboard/asus/p8x7x-series/variants/p8h77-v/overridetree.cb @@ -20,7 +20,6 @@ chip northbridge/intel/sandybridge { 1, 0, 5 }, { 1, 0, 6 } }" - register "gen1_dec" = "0x000c0291" device ref pcie_rp1 on end # PCIEX16_2 (electrical x4) device ref pcie_rp5 on end # AR8161 GbE NIC device ref pcie_rp6 on end # ASM1083 PCI Bridge diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb b/src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb index 058ce7644b..9fb5b6f766 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb +++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb @@ -5,7 +5,6 @@ chip northbridge/intel/sandybridge subsystemid 0x1043 0x84ca inherit device ref peg11 hidden end # These don't exist on this board chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH - register "gen1_dec" = "0x000c0291" register "usb_port_config" = "{ {1, 8, 0}, /* Port 0: USB3 front internal header, top */ {1, 8, 0}, /* Port 1: USB3 front internal header, bottom */ diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/overridetree.cb b/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/overridetree.cb index 5cbfaa2b02..0689696da2 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/overridetree.cb +++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/overridetree.cb @@ -4,7 +4,6 @@ chip northbridge/intel/sandybridge device domain 0 on subsystemid 0x1043 0x84ca inherit chip southbridge/intel/bd82x6x - register "gen1_dec" = "0x000c0291" register "gen4_dec" = "0x0000ff29" register "pcie_port_coalesce" = "true" register "usb_port_config" = "{ diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-v/overridetree.cb b/src/mainboard/asus/p8x7x-series/variants/p8z77-v/overridetree.cb index adbb10a3b6..320e719964 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8z77-v/overridetree.cb +++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-v/overridetree.cb @@ -21,7 +21,6 @@ chip northbridge/intel/sandybridge { 1, 2, 5 }, { 1, 2, 6 } }" - register "gen1_dec" = "0x000c0291" device ref gbe on end device ref pcie_rp1 on end # PCIEX_16_3 (electrical x1 or x4) diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-v_le_plus/overridetree.cb b/src/mainboard/asus/p8x7x-series/variants/p8z77-v_le_plus/overridetree.cb index 66c8467935..31edc0baab 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8z77-v_le_plus/overridetree.cb +++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-v_le_plus/overridetree.cb @@ -23,7 +23,6 @@ chip northbridge/intel/sandybridge { 1, 0xa53, 5 }, { 1, 0xa53, 6 } }" - register "gen1_dec" = "0x000c0291" # NCT6779 HWM register "gen4_dec" = "0x0000ff29" # Could be for KB3722 EC device ref pcie_rp1 on # PCIEX_16_3 (electrical x2 or x4) diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/overridetree.cb b/src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/overridetree.cb index 4d8124a236..926d9d1c15 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/overridetree.cb +++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/overridetree.cb @@ -21,8 +21,6 @@ chip northbridge/intel/sandybridge { 1, 0, 6 } }" - register "gen1_dec" = "0x000c0291" - device ref pcie_rp1 on end # PCIEX16_2 (electrical x4) device ref pcie_rp5 on end # RTL8111 GbE NIC device ref pcie_rp6 on end # ASM1083 PCI Bridge