erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

veyron*: use gpio_base2_value() in board_id()

Browse source 
This makes board_id() use the generic gpio_base2_value() function
to obtain the value of the board ID straps.

BUG=none
BRANCH=none
TEST=tested on pinky

Signed-off-by: David Hendricks <dhendrix@chromium.org>
Change-Id: I5847bf1c5b26bcaf7d36103f31bb255b31ff8185
Reviewed-on: https://chromium-review.googlesource.com/228370
Reviewed-by: Julius Werner <jwerner@chromium.org>
This commit is contained in:
David Hendricks 2014-11-07 13:48:49 -08:00 • committed by chrome-internal-fetch
commit fcbb8a6998
2 changed files with 4 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/mainboard/google/veyron_jerry/boardid.c
View file

@ -25,17 +25,11 @@
uint8_t board_id(void)
{
static int id = -1;
static const gpio_t pins[] = {[3] = GPIO(2, A, 7), [2] = GPIO(2, A, 2),
static gpio_t pins[] = {[3] = GPIO(2, A, 7), [2] = GPIO(2, A, 2),
[1] = GPIO(2, A, 1), [0] = GPIO(2, A, 0)}; /* GPIO2_A0 is LSB */
if (id < 0) {
int i;
id = 0;
for (i = 0; i < ARRAY_SIZE(pins); i++) {
gpio_input(pins[i]);
id |= gpio_get(pins[i]) << i;
}
id = gpio_base2_value(pins, ARRAY_SIZE(pins));
printk(BIOS_SPEW, "Board ID: %d.\n", id);
}

10
src/mainboard/google/veyron_pinky/boardid.c
View file

@ -25,17 +25,11 @@
uint8_t board_id(void)
{
static int id = -1;
static const gpio_t pins[] = {[3] = GPIO(2, A, 7), [2] = GPIO(2, A, 2),
static gpio_t pins[] = {[3] = GPIO(2, A, 7), [2] = GPIO(2, A, 2),
[1] = GPIO(2, A, 1), [0] = GPIO(2, A, 0)}; /* GPIO2_A0 is LSB */
if (id < 0) {
int i;
id = 0;
for (i = 0; i < ARRAY_SIZE(pins); i++) {
gpio_input(pins[i]);
id |= gpio_get(pins[i]) << i;
}
id = gpio_base2_value(pins, ARRAY_SIZE(pins));
printk(BIOS_SPEW, "Board ID: %d.\n", id);
}