From fbf0087918dff2cd1b914cf6ae84027428888f51 Mon Sep 17 00:00:00 2001 From: Pierce Chou Date: Fri, 9 Jan 2026 13:53:19 +0800 Subject: [PATCH] mb/google/ocelot/var/ocicat: Use GPP_F10 for ISH Currently, Linux is unable to load the ISH firmware, as GPP_F10 define lost Update gpio pins GPP_F10 for ISH bug=b:465776760 TEST=Flash and boot to OS on ocicat, Verified ISH fw load in cpu console using below command. ~ # dmesg | grep ish output: intel_ish_ipc 0000:00:12.0: ISH loader: load firmware: intel/ish/ish_wcl.bin Change-Id: I4642560d3b14560e93158d1d19b496e22811600c Signed-off-by: Pierce Chou Reviewed-on: https://review.coreboot.org/c/coreboot/+/90708 Reviewed-by: Paul Menzel Reviewed-by: Pranava Y N Tested-by: build bot (Jenkins) --- src/mainboard/google/ocelot/variants/ocicat/gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/google/ocelot/variants/ocicat/gpio.c b/src/mainboard/google/ocelot/variants/ocicat/gpio.c index 3a9a7b4ed2..25aa28c73b 100644 --- a/src/mainboard/google/ocelot/variants/ocicat/gpio.c +++ b/src/mainboard/google/ocelot/variants/ocicat/gpio.c @@ -242,7 +242,7 @@ static const struct pad_config gpio_table[] = { /* GPP_F09: M2_UFS_RST_N */ PAD_CFG_GPO(GPP_F09, 1, DEEP), /* GPP_F10: ISH_ACCEL_MB_INT_L */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_F05, NONE, DEEP, NF8), + PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_F10, NONE, DEEP, NF8), /* GPP_F11: NC */ PAD_NC(GPP_F11, NONE), /* GPP_F12: THC_I2C1_SCL_TCH_PAD */