From f96644e7743c26fb33dd99745675507f90ab285f Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sun, 22 Feb 2026 15:54:39 +0100 Subject: [PATCH] nb/intel/haswell: Do not print ME status twice The `intel_early_me_init_done()` function prints the ME status. In order to see the ME status once in all paths, have the aforementioned function only call `intel_early_me_status()` before handling a reset request. Change-Id: I42ad1b25889a21047b7cf55e7940293e73794d8b Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/91374 Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) Reviewed-by: Benjamin Doron Reviewed-by: Matt DeVillier --- src/southbridge/intel/lynxpoint/early_me.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/southbridge/intel/lynxpoint/early_me.c b/src/southbridge/intel/lynxpoint/early_me.c index 07013c5539..6dab65238e 100644 --- a/src/southbridge/intel/lynxpoint/early_me.c +++ b/src/southbridge/intel/lynxpoint/early_me.c @@ -159,9 +159,6 @@ int intel_early_me_init_done(u8 status) printk(BIOS_NOTICE, "ME: Requested BIOS Action: %s\n", me_ack_values[hfs.ack_data]); - /* Check status after acknowledgement */ - intel_early_me_status(); - reset = 0; switch (hfs.ack_data) { case ME_HFS_ACK_CONTINUE: @@ -190,6 +187,9 @@ int intel_early_me_init_done(u8 status) /* Perform the requested reset */ if (reset) { + /* Show ME status before resetting */ + intel_early_me_status(); + outb(reset, 0xcf9); halt(); }