From f895289a368f63c31df58219f7f3312cbb98f467 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 2 Apr 2025 13:29:45 +0100 Subject: [PATCH] mb/starlabs/starbook/*: Tidy GPIO comments for display outputs This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: Ib86d4b0193fc78123ab3451e92865bff2bab5bd6 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/87106 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- .../starlabs/byte_adl/variants/mk_ii/gpio.c | 17 ++++++-------- .../starlabs/starbook/variants/adl/gpio.c | 17 ++++++-------- .../starlabs/starbook/variants/cml/gpio.c | 17 ++++++-------- .../starlabs/starbook/variants/kbl/gpio.c | 17 ++++++-------- .../starlabs/starbook/variants/mtl/gpio.c | 23 ++++++++----------- .../starlabs/starbook/variants/rpl/gpio.c | 23 ++++++++----------- .../starlabs/starbook/variants/tgl/gpio.c | 23 ++++++++----------- .../starlabs/starfighter/variants/rpl/gpio.c | 23 ++++++++----------- .../starlite_adl/variants/mk_v/gpio.c | 20 +++++++--------- 9 files changed, 72 insertions(+), 108 deletions(-) diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index 8653f4b015..f60a42d602 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -49,6 +49,13 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_E3, 1, DEEP), /* WiFi RF Kill */ PAD_CFG_GPO(GPP_A13, 1, DEEP), /* Bluetooth RF Kill */ + /* Display */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* eDP Hot Plug */ + PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* HDMI Hot Plug */ + PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* HDMI Clock */ + PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* HDMI Data */ + PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* TCP0 Hot Plug */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -82,10 +89,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_A16, NONE, DEEP, NF1), /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), - /* A18: DDI B DP HPD */ - PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), - /* A19: TCP0 HPD */ - PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* A20: Test Point 2 */ PAD_NC(GPP_A20, NONE), /* A21: Fingerprint Reader Interrupt */ @@ -271,8 +274,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_E12, NONE), /* E13: Not connected */ PAD_NC(GPP_E13, NONE), - /* E14: EDP HPD */ - PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* E15: Not Connected LAN RESET */ PAD_NC(GPP_E15, NONE), /* E16: Not Connected */ @@ -355,12 +356,8 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_H13, NONE), /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), - /* H15: DDPB Control Clock */ - PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* H16: Not Connected */ PAD_NC(GPP_H16, NONE), - /* H17: DDPB Control Data */ - PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* H18: CPI C10 Gate */ PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* H19: Clock Request 4 */ diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index 60786b5230..f98a8990ee 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -50,6 +50,13 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_E3, 1, DEEP), /* WiFi RF Kill */ PAD_CFG_GPO(GPP_A13, 1, DEEP), /* Bluetooth RF Kill */ + /* Display */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* eDP Hot Plug */ + PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* HDMI Hot Plug */ + PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* HDMI Clock */ + PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* HDMI Data */ + PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* TCP0 Hot Plug */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -83,10 +90,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_A16, NONE), /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), - /* A18: DDI B DP HPD */ - PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), - /* A19: TCP0 HPD */ - PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* A20: Test Point 44 */ PAD_NC(GPP_A20, NONE), /* A21: Fingerprint Reader Interrupt */ @@ -267,8 +270,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* E13: Not connected */ PAD_NC(GPP_E13, NONE), - /* E14: EDP HPD */ - PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* E15: Not Connected */ PAD_NC(GPP_E15, NONE), /* E16: Not Connected */ @@ -357,12 +358,8 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_H13, NONE, DEEP, NF5), /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), - /* H15: DDPB Control Clock */ - PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* H16: Not Connected */ PAD_NC(GPP_H16, NONE), - /* H17: DDPB Control Data */ - PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* H18: CPI C10 Gate */ PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* H19: Clock Request 4 CPU M.2 SSD */ diff --git a/src/mainboard/starlabs/starbook/variants/cml/gpio.c b/src/mainboard/starlabs/starbook/variants/cml/gpio.c index 8f2ca8223d..4159f258a6 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/cml/gpio.c @@ -52,6 +52,13 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_C2, 1, DEEP), /* WiFi RF Kill */ PAD_CFG_GPO(GPP_B4, 1, DEEP), /* Bluetooth RF Kill */ + /* Display */ + PAD_CFG_NF(GPP_E17, NONE, DEEP, NF1), /* eDP Hot Plug */ + PAD_CFG_NF(GPP_E13, NONE, DEEP, NF1), /* HDMI Hot Plug */ + PAD_CFG_NF(GPP_E18, NONE, DEEP, NF1), /* HDMI Clock */ + PAD_CFG_NF(GPP_E19, NONE, DEEP, NF1), /* HDMI Data */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* TCP0 Hot Plug */ + /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), /* GPD6: SIO_SLP_A# */ @@ -271,20 +278,10 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1), /* E12: GPPC_E12_USB2_OCB_3 */ PAD_CFG_NF(GPP_E12, NONE, DEEP, NF1), - /* E13: DDI1_HPD */ - PAD_CFG_NF(GPP_E13, NONE, DEEP, NF1), - /* E14: DDI2_HPD */ - PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* E15: SMC_SMI_N */ PAD_CFG_GPI_SMI_LOW(GPP_E15, NONE, DEEP, EDGE_SINGLE), /* E16: SMC_SCI_N */ PAD_CFG_GPI_SCI_LOW(GPP_E16, NONE, PLTRST, LEVEL), - /* E17: EDP_HPD */ - PAD_CFG_NF(GPP_E17, NONE, DEEP, NF1), - /* E18: DDI1_DDC_SCL */ - PAD_CFG_NF(GPP_E18, NONE, DEEP, NF1), - /* E19: DDI1_DDC_SDA */ - PAD_CFG_NF(GPP_E19, NONE, DEEP, NF1), /* E20: DDI2_CTRL_CLK */ PAD_CFG_NF(GPP_E20, NONE, DEEP, NF1), /* E21: DDI2_CTRL_DATA */ diff --git a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c index 47864e84be..b96476d1b0 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c @@ -37,6 +37,13 @@ const struct pad_config gpio_table[] = { // PAD_CFG_GPO(GPP_D20, 1, DEEP), /* WiFi RF Kill */ PAD_CFG_TERM_GPO(GPP_B4, 1, UP_20K, DEEP), /* Bluetooth RF Kill */ + /* Display */ + PAD_CFG_NF(GPP_E17, NONE, DEEP, NF1), /* eDP Hot Plug */ + PAD_CFG_NF(GPP_E13, NONE, DEEP, NF1), /* HDMI Hot Plug */ + PAD_CFG_NF(GPP_E18, NONE, DEEP, NF1), /* HDMI Clock */ + PAD_CFG_NF(GPP_E19, DN_20K, DEEP, NF1), /* HDMI Data */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* TCP0 Hot Plug */ + /* GPD2: Not Connected */ PAD_NC(GPD2, NONE), /* GPD6: Not Connected */ @@ -251,20 +258,10 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1), /* GPP_E12: Not Connected */ PAD_NC(GPP_E12, DN_20K), - /* GPP_E13: DDI1_HPD */ - PAD_CFG_NF(GPP_E13, NONE, DEEP, NF1), - /* GPP_E14: DDI2_HPD */ - PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* E15: SMC_SMI_N */ PAD_CFG_GPI_SMI_LOW(GPP_E15, NONE, DEEP, EDGE_SINGLE), /* E16: SMC_SCI_N */ PAD_CFG_GPI_SCI_LOW(GPP_E16, NONE, PLTRST, LEVEL), - /* GPP_E17: EDP_HPD */ - PAD_CFG_NF(GPP_E17, NONE, DEEP, NF1), - /* GPP_E18: DDI1_DDC_SCL */ - PAD_CFG_NF(GPP_E18, NONE, DEEP, NF1), - /* GPP_E19: DDI1_DDC_SDA */ - PAD_CFG_NF(GPP_E19, DN_20K, DEEP, NF1), /* GPP_E20: Not Connected */ PAD_NC(GPP_E20, DN_20K), /* GPP_E21: DDI2_DDC_SDA */ diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index 89670dd4eb..2eb823095f 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -55,6 +55,15 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_B19, 1, DEEP), /* WiFi RF Kill */ PAD_CFG_GPO(GPP_B18, 1, DEEP), /* Bluetooth RF Kill */ + /* Display */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* eDP Hot Plug */ + PAD_CFG_NF(GPP_B16, NONE, DEEP, NF2), /* HDMI Hot Plug */ + PAD_CFG_NF(GPP_H16, NONE, DEEP, NF1), /* HDMI Clock */ + PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* HDMI Data */ + PAD_CFG_NF(GPP_A21, NONE, DEEP, NF1), /* PMC Interrupt */ + PAD_CFG_NF(GPP_C06, NONE, DEEP, NF1), /* SML Clock */ + PAD_CFG_NF(GPP_C07, NONE, DEEP, NF1), /* SML Data */ + /* V02: PCIE_WAKE_LAN */ PAD_NC(GPP_V02, NONE), /* V06: GPD_6_SLP_A_N */ @@ -111,10 +120,6 @@ const struct pad_config gpio_table[] = { * LOW: ENABLED * WEAK INTERNAL PD 20K */ PAD_CFG_GPO(GPP_C05, 0, PLTRST), - /* C06: SML1_CLK_USBC_PD_N */ - PAD_CFG_NF(GPP_C06, NONE, DEEP, NF1), - /* C07: SML1_DATA_USBC_PD_N */ - PAD_CFG_NF(GPP_C07, NONE, DEEP, NF1), /* C08: SML1ALERT */ PAD_CFG_NF(GPP_C08, NONE, DEEP, NF1), /* C09: */ @@ -182,8 +187,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_A19, NONE), /* A20: M.2_CPU_SSD_RESET_N */ PAD_CFG_GPO(GPP_A20, 1, PLTRST), - /* A21: I2C_PMC_PD_INT_N */ - PAD_CFG_NF(GPP_A21, NONE, DEEP, NF1), /* A22: */ PAD_NC(GPP_A22, NONE), /* A23: */ @@ -225,8 +228,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_E12, NONE), /* E13: */ PAD_NC(GPP_E13, NONE), - /* E14: EDP_HPD_N */ - PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* E15: BOOTHALT_N */ PAD_CFG_NF(GPP_E15, NONE, DEEP, NF2), /* E16: BC_PROCHOT_N */ @@ -276,10 +277,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_H14, NONE), /* H15: */ PAD_NC(GPP_H15, NONE), - /* H16: DDPB_CTRLCLK */ - PAD_CFG_NF(GPP_H16, NONE, DEEP, NF1), - /* H17: DDPB_CTRLDATA */ - PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* H18: */ PAD_NC(GPP_H18, NONE), /* H21: */ @@ -416,8 +413,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_B14, 0, PLTRST), /* B15: */ PAD_NC(GPP_B15, NONE), - /* B16: DDIB_DP_HPD */ - PAD_CFG_NF(GPP_B16, NONE, DEEP, NF2), /* B17: */ PAD_NC(GPP_B17, NONE), /* B20: */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 6e90173e51..1dd2897c71 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -50,6 +50,15 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_E3, 1, DEEP), /* WiFi RF Kill */ PAD_CFG_GPO(GPP_A13, 1, DEEP), /* Bluetooth RF Kill */ + /* Display */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* eDP Hot Plug */ + PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* HDMI Hot Plug */ + PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* HDMI Clock */ + PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* HDMI Data */ + PAD_CFG_NF(GPP_B11, NONE, DEEP, NF1), /* PMC Interrupt */ + PAD_CFG_NF(GPP_C6, NONE, DEEP, NF1), /* SML Clock */ + PAD_CFG_NF(GPP_C7, NONE, DEEP, NF1), /* SML Data */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -84,8 +93,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_A16, NONE, DEEP, NF1), /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), - /* A18: DDI B DP HPD */ - PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* A19: Not Connected */ PAD_NC(GPP_A19, NONE), /* A20: Test Point 44 */ @@ -119,8 +126,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_B9, NONE), /* B10: Not Connected */ PAD_NC(GPP_B10, NONE), - /* B11: I2C PMC PD Interrupt */ - PAD_CFG_NF(GPP_B11, NONE, DEEP, NF1), /* B12: PM SLP S0 */ PAD_NC(GPP_B12, NONE), /* B13: PLT RST */ @@ -170,10 +175,6 @@ const struct pad_config gpio_table[] = { Low: ESPI High: Disabled */ PAD_CFG_GPO(GPP_C5, 0, DEEP), - /* C6: SML 1 Clock */ - PAD_CFG_NF(GPP_C6, NONE, DEEP, NF1), - /* C7: SML 1 Data */ - PAD_CFG_NF(GPP_C7, NONE, DEEP, NF1), /* C8: Not Connected */ PAD_NC(GPP_C8, NONE), /* C9: Not Connected */ @@ -270,8 +271,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* E13: Not connected */ PAD_NC(GPP_E13, NONE), - /* E14: EDP HPD */ - PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* E15: Not Connected */ PAD_NC(GPP_E15, NONE), /* E16: Not Connected */ @@ -360,12 +359,8 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_H13, NONE), /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), - /* H15: DDPB Control Clock */ - PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* H16: Not Connected */ PAD_NC(GPP_H16, NONE), - /* H17: DDPB Control Data */ - PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* H18: CPI C10 Gate */ PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* H20: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index 89985412c1..11b52ceb9a 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -42,6 +42,15 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_F3, NONE, DEEP, NF1), /* RGI Response */ PAD_NC(GPP_F6, NONE), /* Modem Clock Request */ + /* Display */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* eDP Hot Plug */ + PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* HDMI Hot Plug */ + PAD_CFG_NF(GPP_H16, NONE, DEEP, NF1), /* HDMI Clock */ + PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* HDMI Data */ + PAD_CFG_NF(GPP_B11, NONE, DEEP, NF1), /* PMC Interrupt */ + PAD_CFG_NF(GPP_C6, NONE, PWROK, NF1), /* SML Clock */ + PAD_CFG_NF(GPP_C7, NONE, PWROK, NF1), /* SML Data */ + /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), /* GPD6: SIO_SLP_A# */ @@ -76,8 +85,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_A16, NONE, DEEP, NF1), /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), - /* A18: DDIB_HPD */ - PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* A19 Not Connected */ PAD_NC(GPP_A19, NONE), /* A20: Not Connected */ @@ -111,8 +118,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_B9, NONE, DEEP, NF1), /* B10: PWR_MON_I2C_SCL_R */ PAD_CFG_NF(GPP_B10, NONE, DEEP, NF1), - /* B11: I2C_PMC_PD_INT_N */ - PAD_CFG_NF(GPP_B11, NONE, DEEP, NF1), /* B12: PM_SLP_S0_N */ PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), /* B13: PLT_RST_N */ @@ -150,10 +155,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_C4, NONE, DEEP, NF1), /* C5: SML0ALERT_IN */ PAD_CFG_GPO(GPP_C5, 0, DEEP), - /* C6: SML1_CLK */ - PAD_CFG_NF(GPP_C6, NONE, PWROK, NF1), - /* C7: SML1_DATA */ - PAD_CFG_NF(GPP_C7, NONE, PWROK, NF1), /* C9: Not Connected */ PAD_NC(GPP_C9, NONE), /* C10: Not Connected */ @@ -242,8 +243,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_E12, NONE), /* E13: Not Connected */ PAD_NC(GPP_E13, NONE), - /* E14: EDP_HPD */ - PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* E15: Not Connected */ PAD_NC(GPP_E15, NONE), /* E16: Not Connected */ @@ -334,10 +333,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_H14, NONE), /* H15: Not Connected */ PAD_NC(GPP_H15, NONE), - /* H16: DDIB_DDC_SCL */ - PAD_CFG_NF(GPP_H16, NONE, DEEP, NF1), - /* H17: DDIB_DDC_SDA */ - PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* H18: CPU_C10_GATE_N */ PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* H19: UART_BT_WAKE_N */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index 0bf4412862..6b47970c32 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -60,6 +60,15 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_E3, 1, DEEP), /* WiFi RF Kill */ PAD_CFG_GPO(GPP_A13, 1, DEEP), /* Bluetooth RF Kill */ + /* Display */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* eDP Hot Plug */ + PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* HDMI Hot Plug */ + PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* HDMI Clock */ + PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* HDMI Data */ + PAD_CFG_NF(GPP_B11, NONE, DEEP, NF1), /* PMC Interrupt */ + PAD_CFG_NF(GPP_C6, NONE, DEEP, NF1), /* SML Clock */ + PAD_CFG_NF(GPP_C7, NONE, DEEP, NF1), /* SML Data */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -93,8 +102,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_A16, NONE, DEEP, NF1), /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), - /* A18: DDI B DP HPD */ - PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* A19: Not Connected */ PAD_NC(GPP_A19, NONE), /* A20: Test Point 44 */ @@ -128,8 +135,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_B9, NONE), /* B10: Not Connected */ PAD_NC(GPP_B10, NONE), - /* B11: I2C PMC PD Interrupt */ - PAD_CFG_NF(GPP_B11, NONE, DEEP, NF1), /* B12: PM SLP S0 */ PAD_NC(GPP_B12, NONE), /* B13: PLT RST */ @@ -175,10 +180,6 @@ const struct pad_config gpio_table[] = { Low: ESPI High: Disabled */ PAD_CFG_GPO(GPP_C5, 0, DEEP), - /* C6: SML 1 Clock */ - PAD_CFG_NF(GPP_C6, NONE, DEEP, NF1), - /* C7: SML 1 Data */ - PAD_CFG_NF(GPP_C7, NONE, DEEP, NF1), /* C8: Not Connected */ PAD_NC(GPP_C8, NONE), /* C9: Not Connected */ @@ -273,8 +274,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_E12, NONE), /* E13: Not connected */ PAD_NC(GPP_E13, NONE), - /* E14: EDP HPD */ - PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* E15: Not Connected */ PAD_NC(GPP_E15, NONE), /* E16: Not Connected */ @@ -355,12 +354,8 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_H13, NONE), /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), - /* H15: DDPB Control Clock */ - PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* H16: Not Connected */ PAD_NC(GPP_H16, NONE), - /* H17: DDPB Control Data */ - PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* H18: CPI C10 Gate */ PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* H19: Clock Request 4 CPU M.2 SSD */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index 63bda1d78a..0e65185c46 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -49,6 +49,14 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_E3, 1, DEEP), /* WiFi RF Kill */ PAD_CFG_GPO(GPP_A13, 1, DEEP), /* Bluetooth RF Kill */ + /* Display */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* eDP Hot Plug */ + PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* HDMI Hot Plug */ + PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* HDMI Clock */ + PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* HDMI Data */ + PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* TCP0 Hot Plug */ + PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1), /* TCP0 Hot Plug */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -82,12 +90,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_A16, NONE), /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), - /* A18: DDI B DP HPD */ - PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), - /* A19: TCP0 HPD */ - PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), - /* A20: TCP1 HPD */ - PAD_CFG_NF(GPP_A20, NONE, DEEP, NF1), /* A21: Fingerprint Reader Interrupt */ PAD_NC(GPP_A21, NONE), /* A22: Fingerprint Reader Reset */ @@ -269,8 +271,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_E12, NONE), /* E13: Not connected */ PAD_NC(GPP_E13, NONE), - /* E14: EDP HPD */ - PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* E15: Webcam Power Enable */ PAD_NC(GPP_E15, NONE), /* E16: Not Connected */ @@ -353,12 +353,8 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_H13, NONE), /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), - /* H15: DDPB Control Clock */ - PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* H16: Not Connected */ PAD_NC(GPP_H16, NONE), - /* H17: DDPB Control Data */ - PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* H18: CPI C10 Gate */ PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* H19: Clock Request 4 */