From f867d8f76bc57d2ca537e5d804f02d213b74dec6 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Fri, 14 Apr 2023 13:43:43 -0500 Subject: [PATCH] mb/google/dedede: Add non-ChromeOS TBMC support for 360/flip variants The TBMC ACPI device is used by Windows ChromeEC drivers to determine tablet mode and to enable motion sensors (accelerometer, gyroscope). Since it's not needed/used by ChromeOS, restrict its inclusion to non-ChromeOS builds. TEST=build/boot Win11/Linux on magolor, verify tablet mode and rotation work properly, keyboard/touchpad disabled in tablet mode. Change-Id: I6853465ba77be1f95cbe5795b318df02ecc1da39 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/91798 Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) --- .../google/dedede/variants/boten/include/variant/ec.h | 5 +++++ .../google/dedede/variants/bugzzy/include/variant/ec.h | 5 +++++ .../google/dedede/variants/drawcia/include/variant/ec.h | 5 +++++ .../google/dedede/variants/kracko/include/variant/ec.h | 5 +++++ .../google/dedede/variants/madoo/include/variant/ec.h | 5 +++++ .../google/dedede/variants/magolor/include/variant/ec.h | 5 +++++ .../google/dedede/variants/metaknight/include/variant/ec.h | 5 +++++ .../google/dedede/variants/storo/include/variant/ec.h | 5 +++++ 8 files changed, 40 insertions(+) diff --git a/src/mainboard/google/dedede/variants/boten/include/variant/ec.h b/src/mainboard/google/dedede/variants/boten/include/variant/ec.h index 08870e0627..99ff519a84 100644 --- a/src/mainboard/google/dedede/variants/boten/include/variant/ec.h +++ b/src/mainboard/google/dedede/variants/boten/include/variant/ec.h @@ -5,4 +5,9 @@ #include +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif diff --git a/src/mainboard/google/dedede/variants/bugzzy/include/variant/ec.h b/src/mainboard/google/dedede/variants/bugzzy/include/variant/ec.h index 08870e0627..99ff519a84 100644 --- a/src/mainboard/google/dedede/variants/bugzzy/include/variant/ec.h +++ b/src/mainboard/google/dedede/variants/bugzzy/include/variant/ec.h @@ -5,4 +5,9 @@ #include +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif diff --git a/src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h b/src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h index 27c930d4f2..f721a22ec7 100644 --- a/src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h +++ b/src/mainboard/google/dedede/variants/drawcia/include/variant/ec.h @@ -8,4 +8,9 @@ /* Enable Keyboard Backlight in ACPI */ #define EC_ENABLE_KEYBOARD_BACKLIGHT +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif diff --git a/src/mainboard/google/dedede/variants/kracko/include/variant/ec.h b/src/mainboard/google/dedede/variants/kracko/include/variant/ec.h index 08870e0627..99ff519a84 100644 --- a/src/mainboard/google/dedede/variants/kracko/include/variant/ec.h +++ b/src/mainboard/google/dedede/variants/kracko/include/variant/ec.h @@ -5,4 +5,9 @@ #include +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif diff --git a/src/mainboard/google/dedede/variants/madoo/include/variant/ec.h b/src/mainboard/google/dedede/variants/madoo/include/variant/ec.h index d6c3859c91..927b8a62d4 100644 --- a/src/mainboard/google/dedede/variants/madoo/include/variant/ec.h +++ b/src/mainboard/google/dedede/variants/madoo/include/variant/ec.h @@ -8,4 +8,9 @@ /* Enable EC backed Keyboard Backlight in ACPI */ #define EC_ENABLE_KEYBOARD_BACKLIGHT +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif diff --git a/src/mainboard/google/dedede/variants/magolor/include/variant/ec.h b/src/mainboard/google/dedede/variants/magolor/include/variant/ec.h index 27c930d4f2..f721a22ec7 100644 --- a/src/mainboard/google/dedede/variants/magolor/include/variant/ec.h +++ b/src/mainboard/google/dedede/variants/magolor/include/variant/ec.h @@ -8,4 +8,9 @@ /* Enable Keyboard Backlight in ACPI */ #define EC_ENABLE_KEYBOARD_BACKLIGHT +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif diff --git a/src/mainboard/google/dedede/variants/metaknight/include/variant/ec.h b/src/mainboard/google/dedede/variants/metaknight/include/variant/ec.h index 08870e0627..99ff519a84 100644 --- a/src/mainboard/google/dedede/variants/metaknight/include/variant/ec.h +++ b/src/mainboard/google/dedede/variants/metaknight/include/variant/ec.h @@ -5,4 +5,9 @@ #include +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif diff --git a/src/mainboard/google/dedede/variants/storo/include/variant/ec.h b/src/mainboard/google/dedede/variants/storo/include/variant/ec.h index 08870e0627..99ff519a84 100644 --- a/src/mainboard/google/dedede/variants/storo/include/variant/ec.h +++ b/src/mainboard/google/dedede/variants/storo/include/variant/ec.h @@ -5,4 +5,9 @@ #include +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif