erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Exynos5420: clean up SPI driver

Browse source 
That extra struct is not needed, we already defined it earlier on.
Also fix coding style in the file.

BRANCH=none
TEST=boot tested on pit
BUG=none
Signed-off-by: Stefan Reinauer <reinauer@google.com>

Change-Id: I586d290f2f3ba2f44aca7fdee400b88547465599
Reviewed-on: https://chromium-review.googlesource.com/169780
Reviewed-by: Stefan Reinauer <reinauer@google.com>
Commit-Queue: Stefan Reinauer <reinauer@google.com>
Tested-by: Stefan Reinauer <reinauer@google.com>
This commit is contained in:
Stefan Reinauer 2013-09-17 14:08:29 -07:00 • committed by chrome-internal-fetch
commit f7df9f05fb
1 changed files with 14 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

27
src/cpu/samsung/exynos5420/spi.c
View file

@ -345,13 +345,15 @@ struct exynos_spi_media {
struct cbfs_simple_buffer buffer;
};
static int exynos_spi_cbfs_open(struct cbfs_media *media) {
static int exynos_spi_cbfs_open(struct cbfs_media *media)
{
struct exynos_spi_media *spi = (struct exynos_spi_media*)media->context;
DEBUG_SPI("exynos_spi_cbfs_open\n");
return spi_claim_bus(spi->slave);
}
static int exynos_spi_cbfs_close(struct cbfs_media *media) {
static int exynos_spi_cbfs_close(struct cbfs_media *media)
{
struct exynos_spi_media *spi = (struct exynos_spi_media*)media->context;
DEBUG_SPI("exynos_spi_cbfs_close\n");
spi_release_bus(spi->slave);
@ -359,7 +361,8 @@ static int exynos_spi_cbfs_close(struct cbfs_media *media) {
}
static size_t exynos_spi_cbfs_read(struct cbfs_media *media, void *dest,
size_t offset, size_t count) {
size_t offset, size_t count)
{
struct exynos_spi_media *spi = (struct exynos_spi_media*)media->context;
int bytes;
DEBUG_SPI("exynos_spi_cbfs_read(%u)\n", count);
@ -368,7 +371,8 @@ static size_t exynos_spi_cbfs_read(struct cbfs_media *media, void *dest,
}
static void *exynos_spi_cbfs_map(struct cbfs_media *media, size_t offset,
size_t count) {
size_t count)
{
struct exynos_spi_media *spi = (struct exynos_spi_media*)media->context;
DEBUG_SPI("exynos_spi_cbfs_map\n");
// exynos: spi_rx_tx may work in 4 byte-width-transmission mode and
@ -379,7 +383,8 @@ static void *exynos_spi_cbfs_map(struct cbfs_media *media, size_t offset,
}
static void *exynos_spi_cbfs_unmap(struct cbfs_media *media,
const void *address) {
const void *address)
{
struct exynos_spi_media *spi = (struct exynos_spi_media*)media->context;
DEBUG_SPI("exynos_spi_cbfs_unmap\n");
return cbfs_simple_buffer_unmap(&spi->buffer, address);
@ -387,18 +392,14 @@ static void *exynos_spi_cbfs_unmap(struct cbfs_media *media,
int initialize_exynos_spi_cbfs_media(struct cbfs_media *media,
void *buffer_address,
size_t buffer_size) {
size_t buffer_size)
{
// TODO Replace static variable to support multiple streams.
static struct exynos_spi_media context;
static struct exynos_spi_slave eslave = {
.slave = { .bus = 1, .rw = SPI_READ_FLAG, },
.regs = (void*)EXYNOS5_SPI1_BASE,
.fifo_size = 64,
.half_duplex = 0,
};
static struct exynos_spi_slave *eslave = &exynos_spi_slaves[1];
DEBUG_SPI("initialize_exynos_spi_cbfs_media\n");
context.slave = &eslave.slave;
context.slave = &eslave->slave;
context.buffer.allocated = context.buffer.last_allocate = 0;
context.buffer.buffer = buffer_address;
context.buffer.size = buffer_size;