From f78df8aabf8abe7c8952919590e545483119d153 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Thu, 23 Jun 2016 14:00:51 +0300 Subject: [PATCH] UPSTREAM: samsung/lumpy: Fix build with System Agent blob Broken with commit: 2585209 mb/samsung/lumpy/romstage: read SPD data of removable DIMM The blob can pick SPDs from the addresses defined in pei_data and we do only define read_spd() with USE_NATIVE_RAMINIT. Change-Id: Ibd6d7a4a53fa808b476d3060872cb10d3dfce534 Signed-off-by: Kysti Mlkki Reviewed-on: https://review.coreboot.org/15329 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin Reviewed-by: Patrick Rudolph Reviewed-on: https://chromium-review.googlesource.com/355743 Commit-Ready: Furquan Shaikh Tested-by: Furquan Shaikh --- src/mainboard/samsung/lumpy/romstage.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mainboard/samsung/lumpy/romstage.c b/src/mainboard/samsung/lumpy/romstage.c index 4d318b7069..918c73a89f 100644 --- a/src/mainboard/samsung/lumpy/romstage.c +++ b/src/mainboard/samsung/lumpy/romstage.c @@ -216,8 +216,6 @@ void mainboard_fill_pei_data(struct pei_data *pei_data) *pei_data = pei_data_template; // leave onboard dimm address at f0, and copy spd data there. memcpy(pei_data->spd_data[0], locate_spd(), 256); - /* read removable dimm spd */ - read_spd(&pei_data->spd_data[2], 0x50); } const struct southbridge_usb_port mainboard_usb_ports[] = {