From f7512c8647f30863ac4ee5e69c5904e6ade83c20 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Thu, 2 Oct 2025 14:52:34 +0100 Subject: [PATCH] mb/starlabs/starbook/{adl,rpl}: Remove USB OverCurrent Configuration This isn't supported so remove it. Change-Id: I8e8a87f1394199d3288ae27601069ad88e2fa74f Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/89512 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Matt DeVillier --- .../starlabs/starbook/variants/adl/devicetree.cb | 4 ++-- .../starlabs/starbook/variants/rpl/devicetree.cb | 8 ++++---- src/mainboard/starlabs/starbook/variants/rpl/gpio.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index 63d8e6a4d7..675cc27d3b 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -65,14 +65,14 @@ chip soc/intel/alderlake register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Daughterboard USB 3.0 Type-A - register "usb2_ports[6]" = "USB2_PORT_MID(OC0)" + register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Internal Webcam register "usb2_ports[CONFIG_CCD_PORT]" = "USB2_PORT_MID(OC_SKIP)" # Fingerprint Reader - register "usb2_ports[5]" = "USB2_PORT_MID(OC0)" + register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Daughterboard USB 2.0 Type-A + SD Card Reader register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index 8a7652f278..1862070935 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -106,22 +106,22 @@ chip soc/intel/alderlake device ref gna on end device ref xhci on # Motherboard USB TBT Type-C - register "usb2_ports[0]" = "USB2_PORT_MID(OC5)" + register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" register "tcss_ports[0]" = "TCSS_PORT_DEFAULT(OC_SKIP)" # Motherboard USB 3.0 Type-A register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" - register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC5)" + register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Daughterboard USB 3.0 Type-A - register "usb2_ports[6]" = "USB2_PORT_MID(OC0)" + register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Internal Webcam register "usb2_ports[CONFIG_CCD_PORT]" = "USB2_PORT_MID(OC_SKIP)" # Fingerprint Reader - register "usb2_ports[5]" = "USB2_PORT_MID(OC0)" + register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Daughterboard USB 2.0 Type-A + SD Card Reader register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 56ab332835..2fd683a8eb 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -112,7 +112,7 @@ const struct pad_config gpio_table[] = { /* A15: Test Point 52 */ PAD_NC(GPP_A15, NONE), /* A16: USB OverCurrent 3 */ - PAD_CFG_NF(GPP_A16, NONE, DEEP, NF1), + PAD_NC(GPP_A16, NONE), /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), /* A19: Not Connected */ @@ -272,7 +272,7 @@ const struct pad_config gpio_table[] = { /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), /* E9: USB OverCurrent 0 */ - PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), + PAD_NC(GPP_E9, NONE), /* E10: PWD Amplifier Input */ PAD_NC(GPP_E10, NONE), /* E13: Not connected */