From f5f943c1c36f020f8e4dc608c4cc395bd1388f2f Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Sat, 15 Nov 2025 18:48:36 +0000 Subject: [PATCH] bluey/kconfig: Consolidate SPI flash driver selection Simplify board-level Kconfig by consolidating the selection of SPI flash drivers into the common configuration option. Previously, individual board models explicitly selected their specific SPI flash drivers (e.g., SPI_FLASH_MACRONIX, SPI_FLASH_WINBOND). This patch standardizes the approach by: 1. Selecting `SPI_FLASH_INCLUDE_ALL_DRIVERS` in `BOARD_GOOGLE_BLUEY_COMMON`. 2. Removing the redundant vendor-specific selects from `BOARD_GOOGLE_MODEL_BLUEY`, `BOARD_GOOGLE_MODEL_QUENBI`, and `BOARD_GOOGLE_MODEL_QUARTZ`. This change ensures all derived board models inherit the comprehensive set of SPI flash drivers, simplifying maintenance and improving flexibility for multi-vendor support. BUG=b:456953373 TEST=Able to verify that the SPI flash getting correctly probed. Change-Id: I3eb573d0069bfc1d7caab36c9a7a2a223d81c5df Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/90051 Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal --- src/mainboard/google/bluey/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mainboard/google/bluey/Kconfig b/src/mainboard/google/bluey/Kconfig index ffe06eb433..a6ead70307 100644 --- a/src/mainboard/google/bluey/Kconfig +++ b/src/mainboard/google/bluey/Kconfig @@ -8,6 +8,7 @@ config BOARD_GOOGLE_BLUEY_COMMON select MAINBOARD_HAS_CHROMEOS select SPI_FLASH select SPI_FLASH_FORCE_4_BYTE_ADDR_MODE + select SPI_FLASH_INCLUDE_ALL_DRIVERS config BOARD_GOOGLE_BASEBOARD_BLUEY def_bool n @@ -19,7 +20,6 @@ config BOARD_GOOGLE_MODEL_BLUEY select BOARD_ROMSIZE_KB_65536 select MAINBOARD_HAS_FINGERPRINT_VIA_USB select MISSING_BOARD_RESET - select SPI_FLASH_MACRONIX config BOARD_GOOGLE_BLUEY select BOARD_GOOGLE_MODEL_BLUEY @@ -36,7 +36,6 @@ config BOARD_GOOGLE_MODEL_QUENBI select MAINBOARD_HAS_CHROME_EC select MAINBOARD_HAS_FINGERPRINT_VIA_SPI select MAINBOARD_HAS_GOOGLE_TPM - select SPI_FLASH_WINBOND config BOARD_GOOGLE_MODEL_QUARTZ def_bool n @@ -45,7 +44,6 @@ config BOARD_GOOGLE_MODEL_QUARTZ select MAINBOARD_HAS_CHROME_EC select MAINBOARD_HAS_FINGERPRINT_VIA_SPI select MAINBOARD_HAS_GOOGLE_TPM - select SPI_FLASH_INCLUDE_ALL_DRIVERS config BOARD_GOOGLE_QUENBI select BOARD_GOOGLE_MODEL_QUENBI